[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-04 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email )

Change subject: sccp: Drop unused local variable
..

sccp: Drop unused local variable

Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
---
M src/sccp.c
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved




diff --git a/src/sccp.c b/src/sccp.c
index ecab9ab..85bea6d 100644
--- a/src/sccp.c
+++ b/src/sccp.c
@@ -840,7 +840,6 @@
struct msgb *request;
struct sccp_connection_request *req;
uint8_t *data;
-   uint8_t extra_size = 3 + 1;
int called_len;

if (l3_data) {
@@ -850,8 +849,6 @@
}
}

-   if (l3_data)
-   extra_size += 2 + l3_length;
request = msgb_alloc_headroom(SCCP_MSG_SIZE,
  SCCP_MSG_HEADROOM, "sccp connection 
request");
request->l2h = >data[0];

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
Gerrit-Change-Number: 34617
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-04 Thread osmith 
Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email )

Change subject: sccp: Drop unused local variable
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
Gerrit-Change-Number: 34617
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Wed, 04 Oct 2023 10:16:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-03 Thread laforge 
Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email )

Change subject: sccp: Drop unused local variable
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
Gerrit-Change-Number: 34617
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 03 Oct 2023 12:38:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable

2023-10-03 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email )


Change subject: sccp: Drop unused local variable
..

sccp: Drop unused local variable

Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
---
M src/sccp.c
1 file changed, 9 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/17/34617/1

diff --git a/src/sccp.c b/src/sccp.c
index ecab9ab..85bea6d 100644
--- a/src/sccp.c
+++ b/src/sccp.c
@@ -840,7 +840,6 @@
struct msgb *request;
struct sccp_connection_request *req;
uint8_t *data;
-   uint8_t extra_size = 3 + 1;
int called_len;

if (l3_data) {
@@ -850,8 +849,6 @@
}
}

-   if (l3_data)
-   extra_size += 2 + l3_length;
request = msgb_alloc_headroom(SCCP_MSG_SIZE,
  SCCP_MSG_HEADROOM, "sccp connection 
request");
request->l2h = >data[0];

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886
Gerrit-Change-Number: 34617
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange