[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
tnt has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. gsm: Fix comment for TCH/F4.8 code Signed-off-by: Sylvain Munaut Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 --- M utils/conv_codes_gsm.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve tnt: Looks good to me, approved diff --git a/utils/conv_codes_gsm.py b/utils/conv_codes_gsm.py index 721e546..62b5a0b 100644 --- a/utils/conv_codes_gsm.py +++ b/utils/conv_codes_gsm.py @@ -77,7 +77,7 @@ name = "tch_f48", description = [ "TCH/F4.8 convolutional code:", - "152 bits blocks, rate 1/3, k = 5", + "148 bits blocks, rate 1/3, k = 5", "G1 = 1 + D + D3 + D4", "G2 = 1 + D2 + D4", "G3 = 1 + D + D2 + D3 + D4", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: fixeria. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 07 Jul 2023 15:02:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: fixeria. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: (1 comment) File utils/conv_codes_gsm.py: https://gerrit.osmocom.org/c/libosmocore/+/33640/comment/5a50d6e0_5ef7601b PS1, Line 80: 148 bits blocks > Ah, it might be the same case as in Id86d1aa0fd6791a8be431b5547bb723c74c35757. Yeah, the patch didn't update the comment. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Fri, 07 Jul 2023 14:22:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: tnt Gerrit-Comment-Date: Fri, 07 Jul 2023 14:20:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: tnt. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Removed Code-Review+1 by pespin -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: tnt Gerrit-MessageType: deleteVote
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: (1 comment) File utils/conv_codes_gsm.py: https://gerrit.osmocom.org/c/libosmocore/+/33640/comment/27799da6_ba469d94 PS1, Line 80: 148 bits blocks > Hmm, but TS 45.003 section 3.4.3 says 152... Ah, it might be the same case as in Id86d1aa0fd6791a8be431b5547bb723c74c35757. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: tnt Gerrit-Comment-Date: Fri, 07 Jul 2023 14:03:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: (1 comment) File utils/conv_codes_gsm.py: https://gerrit.osmocom.org/c/libosmocore/+/33640/comment/6cf80f4a_3b088708 PS1, Line 80: 148 bits blocks Hmm, but TS 45.003 section 3.4.3 says 152... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: tnt Gerrit-Comment-Date: Fri, 07 Jul 2023 14:01:26 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
Attention is currently required from: tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Attention: tnt Gerrit-Comment-Date: Fri, 07 Jul 2023 14:00:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code .. gsm: Fix comment for TCH/F4.8 code Signed-off-by: Sylvain Munaut Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 --- M utils/conv_codes_gsm.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/33640/1 diff --git a/utils/conv_codes_gsm.py b/utils/conv_codes_gsm.py index 721e546..62b5a0b 100644 --- a/utils/conv_codes_gsm.py +++ b/utils/conv_codes_gsm.py @@ -77,7 +77,7 @@ name = "tch_f48", description = [ "TCH/F4.8 convolutional code:", - "152 bits blocks, rate 1/3, k = 5", + "148 bits blocks, rate 1/3, k = 5", "G1 = 1 + D + D3 + D4", "G2 = 1 + D2 + D4", "G3 = 1 + D + D2 + D3 + D4", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-MessageType: newchange
