[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-29 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

 (

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: osmo_io_poll: Use -errno as result on read error
..

osmo_io_poll: Use -errno as result on read error

Related: OS#5751
Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 12 insertions(+), 1 deletion(-)

Approvals:
  daniel: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  pespin: Looks good to me, approved




diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 472edf9..b6b5908 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -330,6 +330,7 @@
 /*! completion handler: Called by osmo_io backend after a given I/O operation 
has completed
  *  \param[in] iofd I/O file-descriptor on which I/O has completed
  *  \param[in] msg message buffer containing data related to completed I/O
+ *  \param[in] rc result code with read size or error (-errno)
  *  \param[in] hdr serialized msghdr containing state of completed I/O */
 void iofd_handle_recv(struct osmo_io_fd *iofd, struct msgb *msg, int rc, 
struct iofd_msghdr *hdr)
 {
diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c
index 52e806d..74f137b 100644
--- a/src/core/osmo_io_poll.c
+++ b/src/core/osmo_io_poll.c
@@ -74,7 +74,7 @@
if (rc > 0)
msgb_put(msg, rc);

-   iofd_handle_recv(iofd, msg, rc, );
+   iofd_handle_recv(iofd, msg, (rc < 0 && errno > 0) ? -errno : 
rc, );
}

if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED))

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 8
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-29 Thread jolly 
Attention is currently required from: jolly, laforge.

Hello Jenkins Builder, daniel, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email

to look at the new patch set (#8).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: osmo_io_poll: Use -errno as result on read error
..

osmo_io_poll: Use -errno as result on read error

Related: OS#5751
Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35980/8
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 8
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-23 Thread laforge 
Attention is currently required from: jolly, laforge.

laforge has uploaded a new patch set (#7) to the change originally created by 
jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: osmo_io_poll: Use -errno as result on read error
..

osmo_io_poll: Use -errno as result on read error

Related: OS#5751
Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35980/7
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-22 Thread laforge 
Attention is currently required from: jolly, laforge.

laforge has uploaded a new patch set (#6) to the change originally created by 
jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: osmo_io_poll: Use -errno as result on read error
..

osmo_io_poll: Use -errno as result on read error

Related: OS#5751
Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35980/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 6
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-MessageType: newpatchset

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-22 Thread pespin 
Attention is currently required from: jolly, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

Change subject: osmo_io_poll: Use -errno as result on read error
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 5
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Thu, 22 Feb 2024 15:39:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-22 Thread daniel 
Attention is currently required from: jolly, laforge, pespin.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

Change subject: osmo_io_poll: Use -errno as result on read error
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 4
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:48:58 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-22 Thread jolly 
Attention is currently required from: daniel, laforge, pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

Change subject: osmo_io_poll: Use -errno as result on read error
..


Patch Set 4:

(1 comment)

File src/core/osmo_io_poll.c:

https://gerrit.osmocom.org/c/libosmocore/+/35980/comment/34487018_2fe3c836
PS3, Line 76:   iofd_handle_recv(iofd, msg, (rc < 0 && errno > 0) ? 
-errno : rc, );
> Make sure you update the API documentation of iofd_handle_recv() here.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 4
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:00:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-22 Thread jolly 
Attention is currently required from: daniel, jolly, laforge, pespin.

Hello Jenkins Builder, daniel, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder


Change subject: osmo_io_poll: Use -errno as result on read error
..

osmo_io_poll: Use -errno as result on read error

Related: OS#5751
Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35980/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 4
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: daniel 
Gerrit-MessageType: newpatchset

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-20 Thread pespin 
Attention is currently required from: daniel, jolly, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

Change subject: osmo_io_poll: Use -errno as result on read error
..


Patch Set 3: Code-Review+1

(1 comment)

File src/core/osmo_io_poll.c:

https://gerrit.osmocom.org/c/libosmocore/+/35980/comment/609dcc79_a439dc6d
PS3, Line 76:   iofd_handle_recv(iofd, msg, (rc < 0 && errno > 0) ? 
-errno : rc, );
Make sure you update the API documentation of iofd_handle_recv() here.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:21:27 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Use -errno as result on read error

2024-02-19 Thread jolly 
Attention is currently required from: laforge.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email )

Change subject: osmo_io_poll: Use -errno as result on read error
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35980?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ida63b74feecddf96bab7b2ade4e9ad216fe56e06
Gerrit-Change-Number: 35980
Gerrit-PatchSet: 3
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:39:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment