[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 .. scripts/tarballs: gapk > v1.0: use make dist-bzip2 Use autotools logic to build tarballs for gapk above version v1.0. Related: OS#6227 Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 --- M scripts/tarballs/prefer-configure.sh 1 file changed, 28 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/tarballs/prefer-configure.sh b/scripts/tarballs/prefer-configure.sh index f9f8613..295b239 100755 --- a/scripts/tarballs/prefer-configure.sh +++ b/scripts/tarballs/prefer-configure.sh @@ -11,13 +11,22 @@ case "$PROJECT" in gapk) - # Running gapk's configure involves running libgsmhr/fetch_sources.py, - # which according to git log doesn't really work unless using the - # version from master and it looks like we don't want to distribute - # these sources directly... or else we should just add them to the git - # repository and not rely on downloading a remote archive that may just - # change at any time. So create a simple git archive instead. - exit 1 + case "$TAG" in + v0.*|v1.0) + # Running gapk's configure involves running libgsmhr/fetch_sources.py, + # which according to git log doesn't really work unless using the + # version from master and it looks like we don't want to distribute + # these sources directly... or else we should just add them to the git + # repository and not rely on downloading a remote archive that may just + # change at any time. So create a simple git archive instead. + exit 1 + ;; + *) + # Fixed above v1.0 + # https://gerrit.osmocom.org/c/gapk/+/34892/1 + exit 0 + ;; + esac ;; *) exit 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 26 Oct 2023 09:17:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 .. scripts/tarballs: gapk > v1.0: use make dist-bzip2 Use autotools logic to build tarballs for gapk above version v1.0. Related: OS#6227 Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 --- M scripts/tarballs/prefer-configure.sh 1 file changed, 28 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/01/34901/1 diff --git a/scripts/tarballs/prefer-configure.sh b/scripts/tarballs/prefer-configure.sh index f9f8613..295b239 100755 --- a/scripts/tarballs/prefer-configure.sh +++ b/scripts/tarballs/prefer-configure.sh @@ -11,13 +11,22 @@ case "$PROJECT" in gapk) - # Running gapk's configure involves running libgsmhr/fetch_sources.py, - # which according to git log doesn't really work unless using the - # version from master and it looks like we don't want to distribute - # these sources directly... or else we should just add them to the git - # repository and not rely on downloading a remote archive that may just - # change at any time. So create a simple git archive instead. - exit 1 + case "$TAG" in + v0.*|v1.0) + # Running gapk's configure involves running libgsmhr/fetch_sources.py, + # which according to git log doesn't really work unless using the + # version from master and it looks like we don't want to distribute + # these sources directly... or else we should just add them to the git + # repository and not rely on downloading a remote archive that may just + # change at any time. So create a simple git archive instead. + exit 1 + ;; + *) + # Fixed above v1.0 + # https://gerrit.osmocom.org/c/gapk/+/34892/1 + exit 0 + ;; + esac ;; *) exit 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
