[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (1 comment) File gtp/gtp.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/6c8690c8_c0d44bed PS2, Line 106: #define GTPCAUSE_129 129/* For future use 129-176 */ > Agree, please submit a patch dropping all of them. See https://gerrit.osmocom.org/c/osmo-ggsn/+/35162 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 29 Nov 2023 15:42:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (1 comment) File gtp/gtp.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/0615ecd5_413c5d61 PS2, Line 106: #define GTPCAUSE_129 129/* For future use 129-176 */ > I'm not opposed, but then that would mean removing all eight of these > defines: […] Agree, please submit a patch dropping all of them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 29 Nov 2023 14:59:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (2 comments) File gtp/gtp.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/f62b203f_67e652e1 PS2, Line 106: #define GTPCAUSE_129 129/* For future use 129-176 */ > You broke the API compat here. […] I'm not opposed, but then that would mean removing all eight of these defines: ```c #define GTPCAUSE_0066 /* For future use 6-48 */ #define GTPCAUSE_049 49 /* Cause values reserved for GPRS charging protocol use (See GTP' in GSM 12.15) 49-63 */ #define GTPCAUSE_064 64 /* For future use 64-127 */ #define GTPCAUSE_131 131 /* For future use 131-176 */ #define GTPCAUSE_177 177 /* Cause values reserved for GPRS charging protocol use (See GTP' In GSM 12.15) 177-191 */ #define GTPCAUSE_198 198 /* For future use */ #define GTPCAUSE_221 221 /* For Future Use 221-240 */ #define GTPCAUSE_241 241 /* Cause Values Reserved For Gprs Charging Protocol Use (See Gtp' In Gsm 12.15) 241-255 */ ``` Having one value defined for a range is pretty useless anyway. https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/b39e4a66_057fb93c PS2, Line 142: static inline bool gtp_cause_successful(uint8_t cause) > not sure this is really useful to have here, I'd would have left it for the > specific app. […] It's used directly in libgtp as well: https://gerrit.osmocom.org/c/osmo-ggsn/+/35125 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 29 Nov 2023 14:45:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (2 comments) File gtp/gtp.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/155c0048_6102e8d1 PS2, Line 106: #define GTPCAUSE_129 129/* For future use 129-176 */ You broke the API compat here. If we deem these not necessary, then simply leave the comment and remove the defines, so that we don't keep updating (removing and adding) them. https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/b4a98099_63dc652a PS2, Line 142: static inline bool gtp_cause_successful(uint8_t cause) not sure this is really useful to have here, I'd would have left it for the specific app. In any case one usually wants to check the exact cause in order to act differently here AFAIR. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Attention: daniel Gerrit-Comment-Date: Mon, 27 Nov 2023 16:54:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
daniel has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
gtp: Add net GTP cause values and a function to check for success
According to the spec the upf/pgw can accept a modified pdp context from
the request e.g. if an ipv4/6 context was requested, but only ipv4 is
availiable. Introduce a function that checks all cause values that are
considered successful.
See also: 3GPP TS 29.060 Ch 7.3.2
Related: OS#6268
Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
---
M gtp/gtp.h
1 file changed, 27 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/gtp/gtp.h b/gtp/gtp.h
index ede6f73..c066fa6 100644
--- a/gtp/gtp.h
+++ b/gtp/gtp.h
@@ -103,7 +103,9 @@
#define GTPCAUSE_049 49 /* Cause values reserved for
GPRS charging protocol use (See GTP' in GSM 12.15) 49-63 */
#define GTPCAUSE_064 64 /* For future use 64-127 */
#define GTPCAUSE_ACC_REQ 128 /* Request accepted */
-#define GTPCAUSE_129 129 /* For future use 129-176 */
+#define GTPCAUSE_NEW_PDP_NET_PREF 129 /* New PDP type due to network
preference */
+#define GTPCAUSE_NEW_PDP_ADDR_BEAR130 /* New PDP type due to single
address bearer only */
+#define GTPCAUSE_131 131 /* For future use 131-176 */
#define GTPCAUSE_177 177 /* Cause values reserved for
GPRS charging protocol use (See GTP' In GSM 12.15) 177-191 */
#define GTPCAUSE_NON_EXIST192 /* Non-existent */
#define GTPCAUSE_INVALID_MESSAGE 193 /* Invalid message format */
@@ -137,6 +139,13 @@
#define GTPCAUSE_221 221 /* For Future Use 221-240 */
#define GTPCAUSE_241 241 /* Cause Values Reserved For
Gprs Charging Protocol Use (See Gtp' In Gsm 12.15) 241-255 */
+static inline bool gtp_cause_successful(uint8_t cause)
+{
+ return cause == GTPCAUSE_ACC_REQ ||
+ cause == GTPCAUSE_NEW_PDP_NET_PREF ||
+ cause == GTPCAUSE_NEW_PDP_ADDR_BEAR;
+}
+
struct ul66_t;
struct ul16_t;
struct pdp_t;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 2
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Attention: laforge Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 22 Nov 2023 11:40:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (1 comment) Patchset: PS2: +2 from before after lint fixes -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Attention: laforge Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 22 Nov 2023 11:40:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel, laforge, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 22 Nov 2023 11:38:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel, laforge, lynxis lazus, osmith. Hello Jenkins Builder, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by lynxis lazus, Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: gtp: Add net GTP cause values and a function to check for success .. gtp: Add net GTP cause values and a function to check for success According to the spec the upf/pgw can accept a modified pdp context from the request e.g. if an ipv4/6 context was requested, but only ipv4 is availiable. Introduce a function that checks all cause values that are considered successful. See also: 3GPP TS 29.060 Ch 7.3.2 Related: OS#6268 Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 --- M gtp/gtp.h 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/84/35084/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Attention: lynxis lazus Gerrit-MessageType: newpatchset
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel, laforge.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
Patch Set 1: Code-Review+1
(1 comment)
File gtp/gtp.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/60a72f2c_965173d8
PS1, Line 142: static inline bool gtp_cause_successful(uint8_t cause) {
> I want to use it in osmo-sgsn (see OS#6268)
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-Attention: laforge
Gerrit-Attention: daniel
Gerrit-Comment-Date: Wed, 22 Nov 2023 08:11:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith
Comment-In-Reply-To: daniel
Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: laforge, osmith.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
Patch Set 1:
(1 comment)
File gtp/gtp.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/60144fe8_6c27e94e
PS1, Line 142: static inline bool gtp_cause_successful(uint8_t cause) {
> where does the function get used?
I want to use it in osmo-sgsn (see OS#6268)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-Attention: osmith
Gerrit-Attention: laforge
Gerrit-Comment-Date: Wed, 22 Nov 2023 08:10:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel, laforge.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
Patch Set 1:
(1 comment)
File gtp/gtp.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/9fa919a6_0b563104
PS1, Line 142: static inline bool gtp_cause_successful(uint8_t cause) {
where does the function get used?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: osmith
Gerrit-Attention: laforge
Gerrit-Attention: daniel
Gerrit-Comment-Date: Wed, 22 Nov 2023 07:36:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Attention is currently required from: daniel, laforge, osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: see linting otherwise +2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68 Gerrit-Change-Number: 35084 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: daniel Gerrit-Comment-Date: Tue, 21 Nov 2023 16:49:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
Patch Set 1:
(1 comment)
File gtp/gtp.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12540):
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084/comment/bee74660_30f4796a
PS1, Line 142: static inline bool gtp_cause_successful(uint8_t cause) {
open brace '{' following function definitions go on the next line
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 21 Nov 2023 16:16:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email )
Change subject: gtp: Add net GTP cause values and a function to check for
success
..
gtp: Add net GTP cause values and a function to check for success
According to the spec the upf/pgw can accept a modified pdp context from
the request e.g. if an ipv4/6 context was requested, but only ipv4 is
availiable. Introduce a function that checks all cause values that are
considered successful.
See also: 3GPP TS 29.060 Ch 7.3.2
Related: OS#6268
Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
---
M gtp/gtp.h
1 file changed, 26 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/84/35084/1
diff --git a/gtp/gtp.h b/gtp/gtp.h
index ede6f73..256bbbd 100644
--- a/gtp/gtp.h
+++ b/gtp/gtp.h
@@ -103,7 +103,9 @@
#define GTPCAUSE_049 49 /* Cause values reserved for
GPRS charging protocol use (See GTP' in GSM 12.15) 49-63 */
#define GTPCAUSE_064 64 /* For future use 64-127 */
#define GTPCAUSE_ACC_REQ 128 /* Request accepted */
-#define GTPCAUSE_129 129 /* For future use 129-176 */
+#define GTPCAUSE_NEW_PDP_NET_PREF 129 /* New PDP type due to network
preference */
+#define GTPCAUSE_NEW_PDP_ADDR_BEAR130 /* New PDP type due to single
address bearer only */
+#define GTPCAUSE_131 131 /* For future use 131-176 */
#define GTPCAUSE_177 177 /* Cause values reserved for
GPRS charging protocol use (See GTP' In GSM 12.15) 177-191 */
#define GTPCAUSE_NON_EXIST192 /* Non-existent */
#define GTPCAUSE_INVALID_MESSAGE 193 /* Invalid message format */
@@ -137,6 +139,12 @@
#define GTPCAUSE_221 221 /* For Future Use 221-240 */
#define GTPCAUSE_241 241 /* Cause Values Reserved For
Gprs Charging Protocol Use (See Gtp' In Gsm 12.15) 241-255 */
+static inline bool gtp_cause_successful(uint8_t cause) {
+ return cause == GTPCAUSE_ACC_REQ ||
+ cause == GTPCAUSE_NEW_PDP_NET_PREF ||
+ cause == GTPCAUSE_NEW_PDP_ADDR_BEAR;
+}
+
struct ul66_t;
struct ul16_t;
struct pdp_t;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c3bf64537ef2223e29f8082861fa32fde26bf68
Gerrit-Change-Number: 35084
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
