[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-21 Thread fixeria 
Attention is currently required from: lynxis lazus.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )

Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Why are you removing the log context lines?
Because I am moving setting the log context to the common code path.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Wed, 22 May 2024 03:43:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus 
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-21 Thread fixeria 
fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )

Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..

SMS-over-GSUP: set log context in gsm411_gsup_rx()

Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 12 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve




diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1afdfab..328d047 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -133,9 +133,6 @@
const char *msg_name;
bool msg_is_err;

-   /* Associate logging messages with this subscriber */
-   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
-
/* Determine the message type and name */
msg_is_err = OSMO_GSUP_IS_MSGT_ERROR(gsup_msg->message_type);
switch (gsup_msg->message_type) {
@@ -241,9 +238,6 @@
bool sm_rp_mmts_ind;
int rc;

-   /* Associate logging messages with this subscriber */
-   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
-
LOGP(DLSMS, LOGL_DEBUG, "RX MT-forwardSM-Req\n");

/**
@@ -310,6 +304,9 @@
return -GMM_CAUSE_IMSI_UNKNOWN;
}

+   /* Associate logging messages with this subscriber */
+   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
+
switch (gsup_msg->message_type) {
/* GSM 04.11 code implementing MO SMS */
case OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR:

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-MessageType: merged

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-21 Thread lynxis lazus 
Attention is currently required from: fixeria.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )

Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
Why are you removing the log context lines?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: lynxis lazus 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Tue, 21 May 2024 09:50:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-21 Thread laforge 
Attention is currently required from: fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )

Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Tue, 21 May 2024 08:37:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-17 Thread pespin 
Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )

Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Fri, 17 May 2024 14:24:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

2024-05-17 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email )


Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx()
..

SMS-over-GSUP: set log context in gsm411_gsup_rx()

Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 12 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/61/36861/1

diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1afdfab..328d047 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -133,9 +133,6 @@
const char *msg_name;
bool msg_is_err;

-   /* Associate logging messages with this subscriber */
-   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
-
/* Determine the message type and name */
msg_is_err = OSMO_GSUP_IS_MSGT_ERROR(gsup_msg->message_type);
switch (gsup_msg->message_type) {
@@ -241,9 +238,6 @@
bool sm_rp_mmts_ind;
int rc;

-   /* Associate logging messages with this subscriber */
-   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
-
LOGP(DLSMS, LOGL_DEBUG, "RX MT-forwardSM-Req\n");

/**
@@ -310,6 +304,9 @@
return -GMM_CAUSE_IMSI_UNKNOWN;
}

+   /* Associate logging messages with this subscriber */
+   log_set_context(LOG_CTX_VLR_SUBSCR, vsub);
+
switch (gsup_msg->message_type) {
/* GSM 04.11 code implementing MO SMS */
case OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR:

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507
Gerrit-Change-Number: 36861
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange