[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X5) on MO/MT SMS

2024-05-22 Thread laforge 
Attention is currently required from: fixeria, neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email )

Change subject: libmsc: reset the LU delay timer (X5) on MO/MT SMS
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Wed, 22 May 2024 15:35:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X5) on MO/MT SMS

2024-05-17 Thread pespin 
Attention is currently required from: fixeria, laforge, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email )

Change subject: libmsc: reset the LU delay timer (X5) on MO/MT SMS
..


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
Sounds like this should be part of the initial commit, but fine I guess.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Fri, 17 May 2024 16:10:13 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X5) on MO/MT SMS

2024-05-17 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email )


Change subject: libmsc: reset the LU delay timer (X5) on MO/MT SMS
..

libmsc: reset the LU delay timer (X5) on MO/MT SMS

We don't want to delay the BSSAP/RANAP connection release any longer
than it takes to submit or deliver an SMS.  Thus, whenever a new SMS
transaction is being allocated, drop the LU token.

Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Related: osmo-ttcn3-hacks.git I74fa174ea649adb2112c8e471c0e339a2197a08d
Related: SYS#6913
---
M src/libmsc/gsm_04_11.c
1 file changed, 22 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/36865/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index aa87a19..cbacb43 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -1081,6 +1081,13 @@
else
msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SMS);
}
+
+   /* If we're re-using the existing LU connection, drop the LU 
token.
+* The idea behind this timer is explained in 
msc_a_put_use_lu(). */
+   if (osmo_timer_pending(&msc_a->lu_delay_timer)) {
+   osmo_timer_del(&msc_a->lu_delay_timer);
+   msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING);
+   }
}

/* Init both SMC and SMR state machines */

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange