[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email )
Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
..
Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3
---
M Transceiver52M/Transceiver.cpp
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Hoernchen: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index fed4289..f5ddd9b 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -959,19 +959,18 @@
sprintf(response, "RSP NOHANDOVER 0 %u %u", ts, ss);
}
} else if (match_cmd(command, "SETMAXDLY", )) {
-//set expected maximum time-of-arrival
+//set expected maximum time-of-arrival for Access Bursts
int maxDelay;
sscanf(params, "%d", );
mMaxExpectedDelayAB = maxDelay; // 1 GSM symbol is approx. 1 km
sprintf(response,"RSP SETMAXDLY 0 %d",maxDelay);
} else if (match_cmd(command, "SETMAXDLYNB", )) {
-//set expected maximum time-of-arrival
+//set expected maximum time-of-arrival for Normal Bursts
int maxDelay;
sscanf(params, "%d", );
mMaxExpectedDelayNB = maxDelay; // 1 GSM symbol is approx. 1 km
sprintf(response,"RSP SETMAXDLYNB 0 %d",maxDelay);
} else if (match_cmd(command, "SETRXGAIN", )) {
-//set expected maximum time-of-arrival
int newGain;
sscanf(params, "%d", );
newGain = mRadioInterface->setRxGain(newGain, chan);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3
Gerrit-Change-Number: 35655
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email ) Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 Gerrit-Change-Number: 35655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 23 Jan 2024 10:13:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email ) Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 Gerrit-Change-Number: 35655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: Hoernchen Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 23 Jan 2024 10:11:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email )
Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
..
Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3
---
M Transceiver52M/Transceiver.cpp
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/55/35655/1
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index fed4289..f5ddd9b 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -959,19 +959,18 @@
sprintf(response, "RSP NOHANDOVER 0 %u %u", ts, ss);
}
} else if (match_cmd(command, "SETMAXDLY", )) {
-//set expected maximum time-of-arrival
+//set expected maximum time-of-arrival for Access Bursts
int maxDelay;
sscanf(params, "%d", );
mMaxExpectedDelayAB = maxDelay; // 1 GSM symbol is approx. 1 km
sprintf(response,"RSP SETMAXDLY 0 %d",maxDelay);
} else if (match_cmd(command, "SETMAXDLYNB", )) {
-//set expected maximum time-of-arrival
+//set expected maximum time-of-arrival for Normal Bursts
int maxDelay;
sscanf(params, "%d", );
mMaxExpectedDelayNB = maxDelay; // 1 GSM symbol is approx. 1 km
sprintf(response,"RSP SETMAXDLYNB 0 %d",maxDelay);
} else if (match_cmd(command, "SETRXGAIN", )) {
-//set expected maximum time-of-arrival
int newGain;
sscanf(params, "%d", );
newGain = mRadioInterface->setRxGain(newGain, chan);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3
Gerrit-Change-Number: 35655
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
