[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email ) Change subject: contrib/jenkins: make configure args diff friendly .. contrib/jenkins: make configure args diff friendly Removing new lines in DISTCHECK_CONFIGURE_FLAGS again is needed, as it otherwise fails with: enable-sanitize /bin/bash: line 1: enable-sanitize: command not found Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 --- M contrib/jenkins.sh 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 990e6f4..f896b86 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -85,7 +85,16 @@ export LD_LIBRARY_PATH="$inst/lib" export PATH="$inst/bin:$PATH" -CONFIG="--enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms --with-ipc --with-mstrx $INSTR" +CONFIG=" + --enable-sanitize + --enable-werror + --with-ipc + --with-lms + --with-mstrx + --with-uhd + --with-usrp1 + $INSTR +" # Additional configure options and depends if [ "$WITH_MANUALS" = "1" ]; then @@ -109,7 +118,7 @@ || cat-testlogs.sh if arch | grep -v -q arm; then - DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE $PARALLEL_MAKE distcheck \ + DISTCHECK_CONFIGURE_FLAGS="$(echo $CONFIG | tr -d '\n')" $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh fi -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email ) Change subject: contrib/jenkins: make configure args diff friendly .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 18 Mar 2024 16:09:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
Attention is currently required from: laforge, osmith, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email ) Change subject: contrib/jenkins: make configure args diff friendly .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Mon, 18 Mar 2024 15:54:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by laforge, Verified-1 by Jenkins Builder Change subject: contrib/jenkins: make configure args diff friendly .. contrib/jenkins: make configure args diff friendly Removing new lines in DISTCHECK_CONFIGURE_FLAGS again is needed, as it otherwise fails with: enable-sanitize /bin/bash: line 1: enable-sanitize: command not found Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 --- M contrib/jenkins.sh 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/30/36330/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: osmith Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email ) Change subject: contrib/jenkins: make configure args diff friendly .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Mon, 18 Mar 2024 12:52:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-trx[master]: contrib/jenkins: make configure args diff friendly
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email ) Change subject: contrib/jenkins: make configure args diff friendly .. contrib/jenkins: make configure args diff friendly Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 --- M contrib/jenkins.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/30/36330/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 990e6f4..8adf9ff 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -85,7 +85,16 @@ export LD_LIBRARY_PATH="$inst/lib" export PATH="$inst/bin:$PATH" -CONFIG="--enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms --with-ipc --with-mstrx $INSTR" +CONFIG=" + --enable-sanitize + --enable-werror + --with-ipc + --with-lms + --with-mstrx + --with-uhd + --with-usrp1 + $INSTR +" # Additional configure options and depends if [ "$WITH_MANUALS" = "1" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I049af384eccdb6f8e5b305ca35de106eeaca3fa8 Gerrit-Change-Number: 36330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
