[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL .. GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL open5gs 125740727e558c7604897eda711d4d40f2906239 changed behavior and is no longer sending the Used-Service-Unit AVP during INITIAL_REQUEST, which makes sense since those values should be only initialized and spec seems to more or less expect it that way, though receiving it at INITIAL time should be accepted too AFAICT. Related: https://github.com/open5gs/open5gs/pull/2721 Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e --- M ggsn_tests/GGSN_Tests.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 5b1f7a1..d6a0403 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -534,7 +534,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 182147d..bafabdf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -363,7 +363,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 01 Nov 2023 13:36:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 01 Nov 2023 11:19:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL .. GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL open5gs 125740727e558c7604897eda711d4d40f2906239 changed behavior and is no longer sending the Used-Service-Unit AVP during INITIAL_REQUEST, which makes sense since those values should be only initialized and spec seems to more or less expect it that way, though receiving it at INITIAL time should be accepted too AFAICT. Related: https://github.com/open5gs/open5gs/pull/2721 Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e --- M ggsn_tests/GGSN_Tests.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/34929/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 5b1f7a1..d6a0403 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -534,7 +534,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 182147d..bafabdf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -363,7 +363,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange