[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 ) Change subject: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable .. S1AP_Emulation: initialize comp_ref member of S1apAssociationTable The comp_ref member in S1apAssociationTable is not initialized. When an item is delted from the S1apAssociationTable, comp_ref is set to null. Let's maintain a consistent state and also set comp_ref to null when the table is initialized. Related: OS#5760 Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 --- M library/S1AP_Emulation.ttcn 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/S1AP_Emulation.ttcn b/library/S1AP_Emulation.ttcn index 9b159d4..38c738b 100644 --- a/library/S1AP_Emulation.ttcn +++ b/library/S1AP_Emulation.ttcn @@ -274,6 +274,7 @@ S1apAssociationTable[i].cgi := omit; S1apAssociationTable[i].tai := omit; S1apAssociationTable[i].nus := valueof(t_NAS_UE_State(g_pars.role)); + S1apAssociationTable[i].comp_ref := null; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 Gerrit-Change-Number: 33910 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 ) Change subject: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 Gerrit-Change-Number: 33910 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Tue, 25 Jul 2023 07:43:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 ) Change subject: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 Gerrit-Change-Number: 33910 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 24 Jul 2023 18:47:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 ) Change subject: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable .. S1AP_Emulation: initialize comp_ref member of S1apAssociationTable The comp_ref member in S1apAssociationTable is not initialized. When an item is delted from the S1apAssociationTable, comp_ref is set to null. Let's maintain a consistent state and also set comp_ref to null when the table is initialized. Related: OS#5760 Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 --- M library/S1AP_Emulation.ttcn 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/33910/1 diff --git a/library/S1AP_Emulation.ttcn b/library/S1AP_Emulation.ttcn index 9b159d4..38c738b 100644 --- a/library/S1AP_Emulation.ttcn +++ b/library/S1AP_Emulation.ttcn @@ -274,6 +274,7 @@ S1apAssociationTable[i].cgi := omit; S1apAssociationTable[i].tai := omit; S1apAssociationTable[i].nus := valueof(t_NAS_UE_State(g_pars.role)); + S1apAssociationTable[i].comp_ref := null; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 Gerrit-Change-Number: 33910 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
