[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email )
Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
..
epdg: Tx MIP6-Feature-Vector in s6b AAR msg
This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.
Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 396ca0e..5710d0c 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -375,7 +375,7 @@
*/
f_epdg_connhldr_S6b_expect_eteid(ete_id);
- S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, hbh_id := hbh_id, ete_id :=
ete_id));
+ S6b.send(ts_DIA_S6b_AAR(g_pars.imsi,
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id,
ete_id := ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn
b/library/DIAMETER_ts29_273_Templates.ttcn
index 5df1cf1..3daf299 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -14,6 +14,7 @@
import from General_Types all;
import from DIAMETER_Types all;
import from DIAMETER_Templates all;
+import from DIAMETER_rfc5447_Templates all;
import from Osmocom_Types all;
import from Misc_Helpers all;
@@ -22,6 +23,13 @@
/* 3GPP TS 29.273 Section 9 */
const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272;
+/* 5.2.3.3 MIP6-Feature-Vector bits */
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_PMIP6_SUPPORTED :=
hex2int('0100'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_ASSIGN_LOCAL_IP :=
hex2int('0800'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_MIP4_SUPPORTED :=
hex2int('1000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_OPTIMIZED_IDLE_MODE_MOBILITY
:= hex2int('2000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED :=
hex2int('4000'H);
+
/***
* SWx 3GPP TS 29.273 section 8
***/
@@ -198,6 +206,7 @@
/* TS 29.273 9.2.2.5.1 AA-Request (AAR) */
template (value) PDU_DIAMETER
ts_DIA_S6b_AAR(template (value) hexstring imsi,
+ template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
template (value) octetstring sess_id := c_def_sess_id,
template (value) charstring orig_host := "pgw.localdomain",
template (value) charstring orig_realm := "localdomain",
@@ -217,7 +226,8 @@
ts_AVP_OriginRealm(orig_realm),
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
- ts_AVP_UserNameImsi(valueof(imsi))
+ ts_AVP_UserNameImsi(valueof(imsi)),
+ ts_AVP_MIP6FeatureVector(mip6_feat_vec)
/* TODO: Lots other optional */
});
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 4
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email ) Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 Gerrit-Change-Number: 34875 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 24 Oct 2023 19:12:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email ) Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 Gerrit-Change-Number: 34875 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 24 Oct 2023 09:05:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg .. epdg: Tx MIP6-Feature-Vector in s6b AAR msg This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273. Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 --- M epdg/EPDG_Tests.ttcn M library/DIAMETER_ts29_273_Templates.ttcn 2 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/34875/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 Gerrit-Change-Number: 34875 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg .. epdg: Tx MIP6-Feature-Vector in s6b AAR msg This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273. Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 --- M epdg/EPDG_Tests.ttcn M library/DIAMETER_ts29_273_Templates.ttcn 2 files changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/34875/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774 Gerrit-Change-Number: 34875 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email )
Change subject: epdg: Tx MIP6-Feature-Vector in s6b AAR msg
..
epdg: Tx MIP6-Feature-Vector in s6b AAR msg
This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.
Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/75/34875/1
diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 396ca0e..5710d0c 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -375,7 +375,7 @@
*/
f_epdg_connhldr_S6b_expect_eteid(ete_id);
- S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, hbh_id := hbh_id, ete_id :=
ete_id));
+ S6b.send(ts_DIA_S6b_AAR(g_pars.imsi,
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id,
ete_id := ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn
b/library/DIAMETER_ts29_273_Templates.ttcn
index ee0cd89..3daf299 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -24,7 +24,11 @@
const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272;
/* 5.2.3.3 MIP6-Feature-Vector bits */
-const uint64_t MIP6_INTEGRATED := '0001'H;
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_PMIP6_SUPPORTED :=
hex2int('0100'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_ASSIGN_LOCAL_IP :=
hex2int('0800'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_MIP4_SUPPORTED :=
hex2int('1000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_OPTIMIZED_IDLE_MODE_MOBILITY
:= hex2int('2000'H);
+const uint64_t DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED :=
hex2int('4000'H);
/***
* SWx 3GPP TS 29.273 section 8
@@ -202,7 +206,7 @@
/* TS 29.273 9.2.2.5.1 AA-Request (AAR) */
template (value) PDU_DIAMETER
ts_DIA_S6b_AAR(template (value) hexstring imsi,
- template (value) MIPv6_NONE_MIP6_Feature_Vector feat_vec,
+ template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
template (value) octetstring sess_id := c_def_sess_id,
template (value) charstring orig_host := "pgw.localdomain",
template (value) charstring orig_realm := "localdomain",
@@ -223,7 +227,7 @@
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
ts_AVP_UserNameImsi(valueof(imsi)),
- ts_AVP_MIP6FeatureVector()
+ ts_AVP_MIP6FeatureVector(mip6_feat_vec)
/* TODO: Lots other optional */
});
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34875?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I47e1f7ff583f60d0d16e151dbfe64fbd33fd7774
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
