[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx Service-Selection in s6b AAR msg

2023-10-24 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email )

Change subject: epdg: Tx Service-Selection in s6b AAR msg
..

epdg: Tx Service-Selection in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 19 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve




diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 5710d0c..580d4d4 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -114,6 +114,7 @@

 type record EPDG_ConnHdlrPars {
hexstring imsi,
+   charstring apn,
charstring ue_ip,

/* TEI (Data) local side */
@@ -143,6 +144,7 @@
 runs on MTC_CT return EPDG_ConnHdlrPars {
var EPDG_ConnHdlrPars pars := {
imsi := f_gen_imsi(imsi_suffix),
+   apn := "internet",
ue_ip := "192.168.123.50",
teid := ''O,
teic := ''O,
@@ -375,7 +377,9 @@
 */
f_epdg_connhldr_S6b_expect_eteid(ete_id);

-   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, 
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id, 
ete_id := ete_id));
+   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi,
+   
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8),
+   g_pars.apn, hbh_id := hbh_id, ete_id := 
ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn 
b/library/DIAMETER_ts29_273_Templates.ttcn
index 3daf299..38355e7 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -207,6 +207,7 @@
 template (value) PDU_DIAMETER
 ts_DIA_S6b_AAR(template (value) hexstring imsi,
   template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
+  template (value) charstring apn,
   template (value) octetstring sess_id := c_def_sess_id,
   template (value) charstring orig_host := "pgw.localdomain",
   template (value) charstring orig_realm := "localdomain",
@@ -227,7 +228,8 @@
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
ts_AVP_UserNameImsi(valueof(imsi)),
-   ts_AVP_MIP6FeatureVector(mip6_feat_vec)
+   ts_AVP_MIP6FeatureVector(mip6_feat_vec),
+   ts_AVP_ServiceSelection(valueof(apn))
/* TODO: Lots other optional */
});


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx Service-Selection in s6b AAR msg

2023-10-24 Thread laforge 
Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email )

Change subject: epdg: Tx Service-Selection in s6b AAR msg
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 24 Oct 2023 19:12:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx Service-Selection in s6b AAR msg

2023-10-24 Thread osmith 
Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email )

Change subject: epdg: Tx Service-Selection in s6b AAR msg
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 24 Oct 2023 09:05:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: epdg: Tx Service-Selection in s6b AAR msg

2023-10-23 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email )


Change subject: epdg: Tx Service-Selection in s6b AAR msg
..

epdg: Tx Service-Selection in s6b AAR msg

This AVP is actually mandatory as per Table 9.1.2.2.1 in TS 29.273.

Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
---
M epdg/EPDG_Tests.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
2 files changed, 19 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/76/34876/1

diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index 5710d0c..580d4d4 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -114,6 +114,7 @@

 type record EPDG_ConnHdlrPars {
hexstring imsi,
+   charstring apn,
charstring ue_ip,

/* TEI (Data) local side */
@@ -143,6 +144,7 @@
 runs on MTC_CT return EPDG_ConnHdlrPars {
var EPDG_ConnHdlrPars pars := {
imsi := f_gen_imsi(imsi_suffix),
+   apn := "internet",
ue_ip := "192.168.123.50",
teid := ''O,
teic := ''O,
@@ -375,7 +377,9 @@
 */
f_epdg_connhldr_S6b_expect_eteid(ete_id);

-   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, 
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8), hbh_id := hbh_id, 
ete_id := ete_id));
+   S6b.send(ts_DIA_S6b_AAR(g_pars.imsi,
+   
int2oct(DIA_TS29_373_MIP6_Feature_Vector_GTPv2_SUPPORTED, 8),
+   g_pars.apn, hbh_id := hbh_id, ete_id := 
ete_id));
alt {
[] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {}
[] S6b.receive(PDU_DIAMETER:?) -> value rx_dia {
diff --git a/library/DIAMETER_ts29_273_Templates.ttcn 
b/library/DIAMETER_ts29_273_Templates.ttcn
index 3daf299..38355e7 100644
--- a/library/DIAMETER_ts29_273_Templates.ttcn
+++ b/library/DIAMETER_ts29_273_Templates.ttcn
@@ -207,6 +207,7 @@
 template (value) PDU_DIAMETER
 ts_DIA_S6b_AAR(template (value) hexstring imsi,
   template (value) MIPv6_NONE_MIP6_Feature_Vector mip6_feat_vec,
+  template (value) charstring apn,
   template (value) octetstring sess_id := c_def_sess_id,
   template (value) charstring orig_host := "pgw.localdomain",
   template (value) charstring orig_realm := "localdomain",
@@ -227,7 +228,8 @@
ts_AVP_DestinationRealm(dest_realm),
ts_AVP_AuthRequestType(AUTHORIZE_ONLY),
ts_AVP_UserNameImsi(valueof(imsi)),
-   ts_AVP_MIP6FeatureVector(mip6_feat_vec)
+   ts_AVP_MIP6FeatureVector(mip6_feat_vec),
+   ts_AVP_ServiceSelection(valueof(apn))
/* TODO: Lots other optional */
});


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34876?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86d01a0f5148e98b7faebbe0e3d7617a6c90b559
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange