[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-05 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )

Change subject: Use uniform log format for default config files
..

Use uniform log format for default config files

Related: OS#6272
Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
---
M contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
M doc/examples/osmo-upf/osmo-upf-create-dev.cfg
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M doc/examples/osmo-upf/osmo-upf.cfg
6 files changed, 31 insertions(+), 15 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, approved
  laforge: Looks good to me, approved




diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
index a6d4635..ab4c4d4 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
@@ -1,4 +1,10 @@
 log stderr
+ logging color 1
+ logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
+ logging print file basename last
+ logging print level 1
  logging level set-all info

 local-addr 127.0.0.2
diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
index d619f54..6655223 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice
  logging level set-all info
  logging level session debug
diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
index 8b77417..b639e96 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice
  logging level set-all info
  logging level session debug
diff --git a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg 
b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
index e69f49c..a4195b9 100644
--- a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
+++ b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000
diff --git a/doc/examples/osmo-upf/osmo-upf-mockup.cfg 
b/doc/examples/osmo-upf/osmo-upf-mockup.cfg
index 1150c34..b5d5c5b 100644
--- a/doc/examples/osmo-upf/osmo-upf-mockup.cfg
+++ b/doc/examples/osmo-upf/osmo-upf-mockup.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000
diff --git a/doc/examples/osmo-upf/osmo-upf.cfg 
b/doc/examples/osmo-upf/osmo-upf.cfg
index 77b6871..3477daa 100644
--- a/doc/examples/osmo-upf/osmo-upf.cfg
+++ b/doc/examples/osmo-upf/osmo-upf.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000

--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-MessageType: merged


[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-05 Thread laforge
Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )

Change subject: Use uniform log format for default config files
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Tue, 05 Dec 2023 17:09:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-05 Thread osmith
Attention is currently required from: jolly.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )

Change subject: Use uniform log format for default config files
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Tue, 05 Dec 2023 15:05:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-05 Thread osmith
Attention is currently required from: jolly.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )

Change subject: Use uniform log format for default config files
..


Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2:
very nice to have this consistent now!



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Tue, 05 Dec 2023 15:05:25 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-01 Thread pespin
Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )

Change subject: Use uniform log format for default config files
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
there seems to be some problem with nftables here @osm...@sysmocom.de



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 01 Dec 2023 15:55:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: Use uniform log format for default config files

2023-12-01 Thread jolly
jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email )


Change subject: Use uniform log format for default config files
..

Use uniform log format for default config files

Related: OS#6272
Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
---
M contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
M doc/examples/osmo-upf/osmo-upf-create-dev.cfg
M doc/examples/osmo-upf/osmo-upf-mockup.cfg
M doc/examples/osmo-upf/osmo-upf.cfg
6 files changed, 31 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/00/35200/1

diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
index a6d4635..ab4c4d4 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg
@@ -1,4 +1,10 @@
 log stderr
+ logging color 1
+ logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
+ logging print file basename last
+ logging print level 1
  logging level set-all info

 local-addr 127.0.0.2
diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
index d619f54..6655223 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice
  logging level set-all info
  logging level session debug
diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg 
b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
index 8b77417..b639e96 100644
--- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
+++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice
  logging level set-all info
  logging level session debug
diff --git a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg 
b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
index e69f49c..a4195b9 100644
--- a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
+++ b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000
diff --git a/doc/examples/osmo-upf/osmo-upf-mockup.cfg 
b/doc/examples/osmo-upf/osmo-upf-mockup.cfg
index 1150c34..b5d5c5b 100644
--- a/doc/examples/osmo-upf/osmo-upf-mockup.cfg
+++ b/doc/examples/osmo-upf/osmo-upf-mockup.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000
diff --git a/doc/examples/osmo-upf/osmo-upf.cfg 
b/doc/examples/osmo-upf/osmo-upf.cfg
index 77b6871..3477daa 100644
--- a/doc/examples/osmo-upf/osmo-upf.cfg
+++ b/doc/examples/osmo-upf/osmo-upf.cfg
@@ -1,11 +1,11 @@
 log stderr
  logging filter all 1
  logging color 1
- logging print level 1
- logging print category 1
  logging print category-hex 0
+ logging print category 1
+ logging timestamp 0
  logging print file basename last
- logging print extended-timestamp 1
+ logging print level 1
  logging level set-all notice

 timer pfcp x24 5000

--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616
Gerrit-Change-Number: 35200
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange