[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-03-15 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..


Patch Set 2:

(1 comment)

File doc/manuals/chapters/running.adoc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15168):
https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/a197aeb0_786a5dfb
PS2, Line 91: * The netfilter framework and nftables is used for `tunmap`: GTP 
tunnel proxying,
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 15 Mar 2024 20:18:59 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-03-15 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..

manual: 'Running': tweak, mention 'tunmap' and 'tunend'

Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
---
M doc/manuals/chapters/running.adoc
1 file changed, 18 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified




diff --git a/doc/manuals/chapters/running.adoc 
b/doc/manuals/chapters/running.adoc
index 683c444..009ec16 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -85,11 +85,11 @@

 OsmoUPF uses two distinct Linux kernel features:

-* The GTP module is used for GTP encapsulation/decapsulation from/to
+* The GTP module is used for `tunend`: GTP encapsulation/decapsulation from/to
   "the internet".

-* The netfilter module is used for GTP tunnel proxying, also known as
-  tunnel forwarding or tunnel mapping.
+* The netfilter framework and nftables is used for `tunmap`: GTP tunnel 
proxying,
+  also known as tunnel forwarding or tunnel mapping.

 .Linux kernel feature usage
 [graphviz]
@@ -97,8 +97,12 @@
 include::upf_gtp_roles.dot[]
 

-GTP kernel module configuration can be omitted for sites that serve only as GTP
-forwarding proxy, without encapsulation/decapsulation of GTP payloads.
+GTP kernel module configuration in the `tunend` section can be omitted for 
sites
+that serve only as GTP forwarding proxy, without encapsulation/decapsulation of
+GTP payloads.
+
+Likewise, netfilter configuration in the `tunmap` section can be omitted for
+sites only serving as GTP tunnel endpoint.

 [[gtp_module]]
 === Configure Linux Kernel GTP Module for `tunend`

--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged


[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-03-15 Thread laforge
Attention is currently required from: neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..


Patch Set 2: Verified+1

(1 comment)

File doc/manuals/chapters/running.adoc:

https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/86f6d8dd_623533e6
PS1, Line 91: The netfilter module
> Unrelated, FYI, netfilter is not actually a module. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Fri, 15 Mar 2024 20:17:33 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-03-15 Thread laforge
Attention is currently required from: neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Fri, 15 Mar 2024 20:17:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-01-24 Thread laforge
Attention is currently required from: neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )

Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..


Patch Set 1: Code-Review+1

(1 comment)

File doc/manuals/chapters/running.adoc:

https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/6ca9bed6_ba140fa9
PS1, Line 91: The netfilter module
Unrelated, FYI, netfilter is not actually a module. Try lsmod | grep netfilter 
and you won't find anything, unlike lsmod  | grep gtp.  Should probably best be 
phrased: "The netfilter framework is used" or if you want to list amodule"The 
netfilter framework and the nf_tables module is used".



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Wed, 24 Jan 2024 08:31:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

2024-01-23 Thread neels
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email )


Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
..

manual: 'Running': tweak, mention 'tunmap' and 'tunend'

Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
---
M doc/manuals/chapters/running.adoc
1 file changed, 17 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/66/35666/1

diff --git a/doc/manuals/chapters/running.adoc 
b/doc/manuals/chapters/running.adoc
index 683c444..32db271 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -85,10 +85,10 @@

 OsmoUPF uses two distinct Linux kernel features:

-* The GTP module is used for GTP encapsulation/decapsulation from/to
+* The GTP module is used for `tunend`: GTP encapsulation/decapsulation from/to
   "the internet".

-* The netfilter module is used for GTP tunnel proxying, also known as
+* The netfilter module is used for `tunmap`: GTP tunnel proxying, also known as
   tunnel forwarding or tunnel mapping.

 .Linux kernel feature usage
@@ -97,8 +97,12 @@
 include::upf_gtp_roles.dot[]
 

-GTP kernel module configuration can be omitted for sites that serve only as GTP
-forwarding proxy, without encapsulation/decapsulation of GTP payloads.
+GTP kernel module configuration in the `tunend` section can be omitted for 
sites
+that serve only as GTP forwarding proxy, without encapsulation/decapsulation of
+GTP payloads.
+
+Likewise, netfilter configuration in the `tunmap` section can be omitted for
+sites only serving as GTP tunnel endpoint.

 [[gtp_module]]
 === Configure Linux Kernel GTP Module for `tunend`

--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27
Gerrit-Change-Number: 35666
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange