[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-10-04 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

 (

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: ASCI: Show NCH position in VTY together with system 
information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve




diff --git a/src/host/layer23/src/common/sysinfo.c 
b/src/host/layer23/src/common/sysinfo.c
index 700accd..7af1d93 100644
--- a/src/host/layer23/src/common/sysinfo.c
+++ b/src/host/layer23/src/common/sysinfo.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 

@@ -72,6 +73,7 @@
char buffer[82];
int i, j, k, index;
int refer_pcs = gsm_refer_pcs(arfcn, s);
+   int rc;

/* available sysinfos */
print(priv, "ARFCN = %s  channels 512+ refer to %s\n",
@@ -282,6 +284,16 @@
print(priv, "  BS-PA-MFMS = %d  Attachment = %s\n",
s->pag_mf_periods, (s->att_allowed) ? "allowed" : "denied");
print(priv, "BS-AG_BLKS_RES = %d  ", s->bs_ag_blks_res);
+   if (!s->nch)
+   print(priv, "NCH not available  ");
+   else {
+   uint8_t num_blocks, first_block;
+   rc = osmo_gsm48_si1ro_nch_pos_decode(s->nch_position, 
_blocks, _block);
+   if (rc < 0)
+   print(priv, "NCH Position invalid  ");
+   else
+   print(priv, "NCH Position %u / %u blocks  ", 
first_block, num_blocks);
+   }
if (s->t3212)
print(priv, "T3212 = %d sec.\n", s->t3212);
else

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 16
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-10-03 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#16).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/16
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 16
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-10-02 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#15).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/15
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 15
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-28 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#14).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/14
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 14
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-28 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#12).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/12
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 12
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-27 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#11).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/11
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 11
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-27 Thread jolly 
Attention is currently required from: jolly.

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#10).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/10
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 10
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-26 Thread laforge 
Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

Change subject: ASCI: Show NCH position in VTY together with system information
..


Patch Set 9: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 9
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Tue, 26 Sep 2023 13:59:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-26 Thread pespin 
Attention is currently required from: jolly, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

Change subject: ASCI: Show NCH position in VTY together with system information
..


Patch Set 9: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 9
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: jolly 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Tue, 26 Sep 2023 12:32:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-26 Thread jolly 
Attention is currently required from: laforge, pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

Change subject: ASCI: Show NCH position in VTY together with system information
..


Patch Set 7:

(1 comment)

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34496/comment/4d169da1_4c0b72a3
PS6, Line 295:  print(priv, "NCH Position %d / %d blocks  ", 
first_block, num_blocks);
> Ack
Done



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Tue, 26 Sep 2023 10:27:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-26 Thread jolly 
Attention is currently required from: jolly, pespin.

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email

to look at the new patch set (#7).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/7
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 7
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-24 Thread laforge 
Attention is currently required from: jolly, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

Change subject: ASCI: Show NCH position in VTY together with system information
..


Patch Set 6:

(1 comment)

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34496/comment/69b18a62_b5faef0b
PS6, Line 295:  print(priv, "NCH Position %d / %d blocks  ", 
first_block, num_blocks);
> %u / %u
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 6
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sun, 24 Sep 2023 17:46:17 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-21 Thread pespin 
Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )

Change subject: ASCI: Show NCH position in VTY together with system information
..


Patch Set 6:

(1 comment)

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34496/comment/f3b54b1d_4e69d2ff
PS6, Line 295:  print(priv, "NCH Position %d / %d blocks  ", 
first_block, num_blocks);
%u / %u



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 6
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Thu, 21 Sep 2023 14:34:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: ASCI: Show NCH position in VTY together with system information

2023-09-21 Thread jolly 
jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email )


Change subject: ASCI: Show NCH position in VTY together with system information
..

ASCI: Show NCH position in VTY together with system information

Related: OS#5364
Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
---
M src/host/layer23/src/common/sysinfo.c
1 file changed, 22 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/34496/1

diff --git a/src/host/layer23/src/common/sysinfo.c 
b/src/host/layer23/src/common/sysinfo.c
index 700accd..e9caea8 100644
--- a/src/host/layer23/src/common/sysinfo.c
+++ b/src/host/layer23/src/common/sysinfo.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 

@@ -72,6 +73,7 @@
char buffer[82];
int i, j, k, index;
int refer_pcs = gsm_refer_pcs(arfcn, s);
+   int rc;

/* available sysinfos */
print(priv, "ARFCN = %s  channels 512+ refer to %s\n",
@@ -282,6 +284,16 @@
print(priv, "  BS-PA-MFMS = %d  Attachment = %s\n",
s->pag_mf_periods, (s->att_allowed) ? "allowed" : "denied");
print(priv, "BS-AG_BLKS_RES = %d  ", s->bs_ag_blks_res);
+   if (!s->nch)
+   print(priv, "NCH not available  ");
+   else {
+   uint8_t num_blocks, first_block;
+   rc = osmo_gsm48_si1ro_nch_pos_decode(s->nch_position, 
_blocks, _block);
+   if (rc < 0)
+   print(priv, "NCH Position invalid  ");
+   else
+   print(priv, "NCH Position %d / %d blocks  ", 
first_block, num_blocks);
+   }
if (s->t3212)
print(priv, "T3212 = %d sec.\n", s->t3212);
else

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34496?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5e0a9d469eb70608502dca881808621fa153b666
Gerrit-Change-Number: 34496
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange