[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS

2023-10-04 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email )

Change subject: Fix settings for VGCS/VBS
..

Fix settings for VGCS/VBS

The "support" flags must be copied to the settings, because they are
enabled by default and may be omitted in the VTY config.

Related: OS#5364
Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
---
M src/host/layer23/src/common/settings.c
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve




diff --git a/src/host/layer23/src/common/settings.c 
b/src/host/layer23/src/common/settings.c
index 288b03e..395d239 100644
--- a/src/host/layer23/src/common/settings.c
+++ b/src/host/layer23/src/common/settings.c
@@ -100,6 +100,8 @@
set->ch_cap = sup->ch_cap;
set->min_rxlev_dbm = sup->min_rxlev_dbm;
set->dsc_max = sup->dsc_max;
+   set->vgcs = sup->vgcs;
+   set->vbs = sup->vbs;

if (sup->half_v1 || sup->half_v3)
set->half = 1;

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
Gerrit-Change-Number: 34644
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS

2023-10-04 Thread fixeria
Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email )

Change subject: Fix settings for VGCS/VBS
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
Gerrit-Change-Number: 34644
Gerrit-PatchSet: 2
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Wed, 04 Oct 2023 12:07:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS

2023-10-04 Thread pespin
Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email )

Change subject: Fix settings for VGCS/VBS
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
Gerrit-Change-Number: 34644
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS

2023-10-04 Thread jolly
jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email )


Change subject: Fix settings for VGCS/VBS
..

Fix settings for VGCS/VBS

The "support" flags must be copied to the settings, because they are
enabled by default and may be omitted in the VTY config.

Related: OS#5364
Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
---
M src/host/layer23/src/common/settings.c
1 file changed, 15 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/44/34644/1

diff --git a/src/host/layer23/src/common/settings.c 
b/src/host/layer23/src/common/settings.c
index 288b03e..395d239 100644
--- a/src/host/layer23/src/common/settings.c
+++ b/src/host/layer23/src/common/settings.c
@@ -100,6 +100,8 @@
set->ch_cap = sup->ch_cap;
set->min_rxlev_dbm = sup->min_rxlev_dbm;
set->dsc_max = sup->dsc_max;
+   set->vgcs = sup->vgcs;
+   set->vbs = sup->vbs;

if (sup->half_v1 || sup->half_v3)
set->half = 1;

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577
Gerrit-Change-Number: 34644
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange