[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId .. osmo-smdpp: fix generation of transactionId The hex string of the generated transactionId contains lowercase hex digits. However SGP.22 explicitly spcifies to use uppercase hex digits when using JSON fromatted messages. See section 6.5.2.6 for example. Related: SYS#6720 Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 --- M osmo-smdpp.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 582b222..1f4311d 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -239,7 +239,7 @@ # Generate a TransactionID which is used to identify the ongoing RSP session. The TransactionID # SHALL be unique within the scope and lifetime of each SM-DP+. -transactionId = uuid.uuid4().hex +transactionId = uuid.uuid4().hex.upper() assert not transactionId in self.rss # Generate a serverChallenge for eUICC authentication attached to the ongoing RSP session. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 15 Mar 2024 15:10:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 15 Mar 2024 14:42:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId
Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId .. Patch Set 1: (1 comment) Patchset: PS1: I noticed that when I compared the output from osmo-smdpp to the output from productive SMDP+ servers. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Fri, 15 Mar 2024 08:34:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in pysim[master]: osmo-smdpp: fix generation of transactionId
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36295?usp=email ) Change subject: osmo-smdpp: fix generation of transactionId .. osmo-smdpp: fix generation of transactionId The hex string of the generated transactionId contains lowercase hex digits. However SGP.22 explicitly spcifies to use uppercase hex digits when using JSON fromatted messages. See section 6.5.2.6 for example. Related: SYS#6720 Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 --- M osmo-smdpp.py 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/95/36295/1 diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 582b222..1f4311d 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -239,7 +239,7 @@ # Generate a TransactionID which is used to identify the ongoing RSP session. The TransactionID # SHALL be unique within the scope and lifetime of each SM-DP+. -transactionId = uuid.uuid4().hex +transactionId = uuid.uuid4().hex.upper() assert not transactionId in self.rss # Generate a serverChallenge for eUICC authentication attached to the ongoing RSP session. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8439aa9d70f6fe798fa88b623bac13debdc19ca1 Gerrit-Change-Number: 36295 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
