[S] Change in pysim[master]: pySim-trace.py: Resolve possible variable use before assignment

2024-05-23 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/pysim/+/36904?usp=email )

Change subject: pySim-trace.py: Resolve possible variable use before assignment
..

pySim-trace.py: Resolve possible variable use before assignment

pySim-trace.py:198:27: E0606: Possibly using variable 's' before assignment 
(possibly-used-before-assignment)

Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935
---
M pySim-trace.py
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/pySim-trace.py b/pySim-trace.py
index be1d40b..165e338 100755
--- a/pySim-trace.py
+++ b/pySim-trace.py
@@ -194,6 +194,8 @@
 s = PysharkRsproLive(opts.interface)
 elif opts.source == 'gsmtap-pyshark-pcap':
 s = PysharkGsmtapPcap(opts.pcap_file)
+else:
+raise ValueError("unsupported source %s", opts.source)

 tracer = Tracer(source=s, suppress_status=opts.suppress_status, 
suppress_select=opts.suppress_select,
 show_raw_apdu=opts.show_raw_apdu)

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36904?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935
Gerrit-Change-Number: 36904
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

[S] Change in pysim[master]: pySim-trace.py: Resolve possible variable use before assignment

2024-05-23 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/36904?usp=email )

Change subject: pySim-trace.py: Resolve possible variable use before assignment
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36904?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935
Gerrit-Change-Number: 36904
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 23 May 2024 14:48:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in pysim[master]: pySim-trace.py: Resolve possible variable use before assignment

2024-05-22 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/36904?usp=email )


Change subject: pySim-trace.py: Resolve possible variable use before assignment
..

pySim-trace.py: Resolve possible variable use before assignment

pySim-trace.py:198:27: E0606: Possibly using variable 's' before assignment 
(possibly-used-before-assignment)

Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935
---
M pySim-trace.py
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/36904/1

diff --git a/pySim-trace.py b/pySim-trace.py
index be1d40b..165e338 100755
--- a/pySim-trace.py
+++ b/pySim-trace.py
@@ -194,6 +194,8 @@
 s = PysharkRsproLive(opts.interface)
 elif opts.source == 'gsmtap-pyshark-pcap':
 s = PysharkGsmtapPcap(opts.pcap_file)
+else:
+raise ValueError("unsupported source %s", opts.source)

 tracer = Tracer(source=s, suppress_status=opts.suppress_status, 
suppress_select=opts.suppress_select,
 show_raw_apdu=opts.show_raw_apdu)

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36904?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935
Gerrit-Change-Number: 36904
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange