[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 01 May 2024 08:03:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Tue, 30 Apr 2024 21:12:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 9: (1 comment) This change is ready for review. Patchset: PS9: Thanks for reviewing. I have only changed a few comments and removed some deleted files that easyrsa had created. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 30 Apr 2024 10:07:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Sun, 28 Apr 2024 12:16:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: laforge Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 26 Apr 2024 11:51:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 8: (2 comments) File ipad/IPAd_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/edeac0e6_8aa0003e PS7, Line 161: f_sleep(2.0); > is this time something configurable in IPAd? If so, add a mp_ float module > parameter and add a comme […] Its not configurable in the iPAD, but it still make sense to give this a module parameter. File ipad/example_ca/pki/issued/alttest.notes: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/810dfd6a_b51b0616 PS7, Line 7: The alttest.cabundle file has been created manually (alttest certificate at the > the certificate which we only use for tests here should not expire in 2027. > […] The time-bomb problem is now fixed. The ca-bundle creation is really that simple, paste the ca-certificate at the bottom and then paste put the signed certificate on top of it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 25 Apr 2024 16:05:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M .checkpatch.conf M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/2AA3F8FFC3B562AFC67845389A5F2C5A.pem A ipad/example_ca/pki/certs_by_serial/FAEE71AC9CF85B804DCE4BD357F83209.pem A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.attr.old A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/issued/testsuite.cabundle A ipad/example_ca/pki/issued/testsuite.crt A ipad/example_ca/pki/issued/testsuite.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/private/testsuite.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/reqs/testsuite.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/pki/vars A ipad/example_ca/pki/vars.example A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 35 files changed, 2,180 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 7: (1 comment) File ipad/example_ca/pki/issued/alttest.notes: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9423e807_ee198700 PS7, Line 7: The alttest.cabundle file has been created manually (alttest certificate at the > Explain how did you create it manually. […] the certificate which we only use for tests here should not expire in 2027. It should have a long expiration date, like 20 years or so. WE do not want to test cert expiration logic here, so let's not create time-bombs. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 24 Apr 2024 17:19:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd
..
Patch Set 7:
(3 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bce29a62_271764bc
PS1, Line 445: for (i := 0; i <
sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87);
i := i + 1) {
> lol. […]
Yeah much better now :)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/295a7b9d_2ce1ce95
PS7, Line 161: f_sleep(2.0);
is this time something configurable in IPAd? If so, add a mp_ float module
parameter and add a comment regarding having to sync that with the config in
IPAd.
File ipad/example_ca/pki/issued/alttest.notes:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/922a94f7_83343aeb
PS7, Line 7: The alttest.cabundle file has been created manually (alttest
certificate at the
Explain how did you create it manually.
Also, explicitly state how to update the certificate when it expires in 2027 ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 7
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Attention: dexter
Gerrit-Comment-Date: Wed, 24 Apr 2024 14:07:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M .checkpatch.conf M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 30 files changed, 1,945 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 6: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c4d5dc85_6c182049 PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a275a220_d72a48b9 PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/8a831858_332e05dd PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9ef18c1c_6756d903 PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c08f20c_36885163 PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bb1033d0_5d965f7b PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9353f380_895823f7 PS6, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c337e41d_247096ca PS6, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/27532674_f568db7a PS6, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fe629262_354221c4 PS6, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/19826810_778efda4 PS6, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/edb942d3_408a61fb PS6, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15772): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/264e6d6f_f935b4f2 PS6, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Tue, 23 Apr 2024 10:19:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 5: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5a161917_a58bb9d5 PS5, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9025cf30_b1249639 PS5, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/75cc4002_38733a7b PS5, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/24e0a23a_b199fa47 PS5, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/26cc0cb4_a63970e1 PS5, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9044f961_d610206d PS5, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7dfaf612_3391979f PS5, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/2e3fee0b_ce09d594 PS5, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/aae267dd_75eaed38 PS5, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a672ad5e_d9af6bb8 PS5, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f3b87cae_8d35d19e PS5, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/44fb7ab7_ba30aa5b PS5, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15758): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/343257f2_ab7ed785 PS5, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 11:49:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 29 files changed, 1,942 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 4: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a1d62da6_d35b4741 PS4, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4f8fb4b1_c4ac3746 PS4, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4c59fe19_6f75bc1a PS4, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e4207886_caa80bfd PS4, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/9d02d153_0c5273ff PS4, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d0a83ad2_2ee2f6cd PS4, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a27780f8_06c7fafd PS4, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/cb75132f_57d051b5 PS4, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e1b3411b_6aa3ee1d PS4, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/dfb8e8cc_35b98e36 PS4, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/41fa99c8_03890521 PS4, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/5659d7a2_a7efea2e PS4, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15753): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ccdbee97_166b7e3a PS4, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: dexter Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd
..
Patch Set 3:
(1 comment)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7d086b52_f220b7f1
PS1, Line 445: for (i := 0; i <
sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87);
i := i + 1) {
> I do not know if this looks much nicer ;-/ […]
lol.
But at least you have it once, not 6 times.
So your eyes only need to do the large line parsing once.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
Gerrit-CC: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: dexter
Gerrit-Comment-Date: Fri, 19 Apr 2024 14:09:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 3: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f46796ca_8b6a8d1a PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bcfd9ef2_60a0e3e2 PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/410f5f26_c1ed6163 PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/7e0621e1_f6312244 PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/bc53f7b7_c376abec PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ec9aabe9_d84e4cd8 PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/78c41c43_a2cf1997 PS3, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/45165c80_b77f38ed PS3, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0024ee70_b84ac930 PS3, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/e6ec6b7d_d1c727b5 PS3, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/37ac2261_2bb8b4c0 PS3, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/de9e96c7_30a219f0 PS3, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15716): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/28191ddc_37fe8440 PS3, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Fri, 19 Apr 2024 11:56:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: dexter, fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/easyrsa A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/example_ca/x509-types A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 29 files changed, 1,940 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email ) Change subject: IPAd_Tests: add testsuite for an IPAd .. Patch Set 2: (13 comments) File ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/3c2b16e3_87433f68 PS2, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/db33ca48_1211c8d9 PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f9b9c8e9_8432387a PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/1316252e_4e71078f PS2, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c388ae46_201855b1 PS2, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/a912d025_4a9bf22c PS2, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/pki/issued/alttest.crt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/fb1c5389_b62ff3a8 PS2, Line 36: X509v3 Basic Constraints: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/ce983c85_69a19cd5 PS2, Line 38: X509v3 Subject Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/f2e9c9cc_3e5508d7 PS2, Line 40: X509v3 Authority Key Identifier: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/88b3d449_8b787c58 PS2, Line 45: X509v3 Extended Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/579ed89c_ea7b59d0 PS2, Line 47: X509v3 Key Usage: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/4e767527_7c73be92 PS2, Line 49: X509v3 Subject Alternative Name: trailing whitespace File ipad/example_ca/vars: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15516): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d6e62e11_9e47a4a6 PS2, Line 30: # trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 02 Apr 2024 15:07:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: IPAd_Tests: add testsuite for an IPAd .. IPAd_Tests: add testsuite for an IPAd With this patch we add a testsuite that can be used to test an IPAd implementation. The testsuite emulates the ESipa and the ES10x (pcsc cardreader) interface and is capable of testing a direct profile download and other ESipa features like the execution of an eIM package (eCO, PSMO). Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Related: SYS#6564 --- M Makefile A ipad/IPAd_Tests.cfg A ipad/IPAd_Tests.default A ipad/IPAd_Tests.ttcn A ipad/example_ca/openssl-easyrsa.cnf A ipad/example_ca/pki/.rnd A ipad/example_ca/pki/ca.crt A ipad/example_ca/pki/certs_by_serial/11192A13CF3A3BC43FE1594BA8567DF0.pem A ipad/example_ca/pki/extensions.temp A ipad/example_ca/pki/index.txt A ipad/example_ca/pki/index.txt.attr A ipad/example_ca/pki/index.txt.old A ipad/example_ca/pki/issued/alttest.cabundle A ipad/example_ca/pki/issued/alttest.crt A ipad/example_ca/pki/issued/alttest.notes A ipad/example_ca/pki/openssl-easyrsa.cnf A ipad/example_ca/pki/openssl-easyrsa.temp A ipad/example_ca/pki/private/alttest.key A ipad/example_ca/pki/private/ca.key A ipad/example_ca/pki/reqs/alttest.req A ipad/example_ca/pki/safessl-easyrsa.cnf A ipad/example_ca/pki/serial A ipad/example_ca/pki/serial.old A ipad/example_ca/vars A ipad/gen_links.sh A ipad/regen_makefile.sh M regen-makefile.sh 27 files changed, 1,863 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36229/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[XL] Change in osmo-ttcn3-hacks[master]: IPAd_Tests: add testsuite for an IPAd
Attention is currently required from: fixeria, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd
..
Patch Set 2:
(5 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/731959b6_c76ed951
PS1, Line 51: function f_make_http_resp
> this looks more like a `template`?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d776d58e_327939dc
PS1, Line 104: modulepar
> not critical, but we usually have module params on top
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c9997b95_78a230f9
PS1, Line 208: while(true)
> cosmetic: while is not a function (same below)
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0e601fe3_fb27b29c
PS1, Line 445: for (i := 0; i <
sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87);
i := i + 1) {
> sounds like you want to put this in a variable ;)
> "esipa_res.getBoundProfilePackageResponseEsipa. […]
I do not know if this looks much nicer ;-/
var RSPDefinitions.BoundProfilePackage.firstSequenceOf87 firstSequenceOf87 :=
esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87;
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/dd96cb3e_15c1dc14
PS1, Line 652: // execute ( TC_add_init_eim() );
> why is this one commented out?
This test requires the IPAd to be called with different command line parameters
and a file that contains the eIM configuration. I have used this testcase
mainly as a vehicle to see what is spoken to the eUICC on the other end. The
testcase does not add much value anyway, so I have removed it now.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d
Gerrit-Change-Number: 36229
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
Gerrit-CC: pespin
Gerrit-Attention: fixeria
Gerrit-Attention: pespin
Gerrit-Comment-Date: Tue, 02 Apr 2024 15:06:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
