Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 ) Change subject: osmux: squash LOGP message to one line .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2bb0ecf4cc165b9a1080e2558b33ba37014278c Gerrit-Change-Number: 15673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 04 Oct 2019 15:48:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 ) Change subject: osmux: squash LOGP message to one line .. osmux: squash LOGP message to one line It seems different compiler versions (jenkins and my workstation) are generating different line number for that message, and it makes osmux_test fail when improving logging on next commit. Change-Id: Ie2bb0ecf4cc165b9a1080e2558b33ba37014278c --- M src/osmux.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmux.c b/src/osmux.c index 9d058b0..c43c3eb 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -366,8 +366,7 @@ if (rtph == NULL) return -1; - LOGP(DLMUX, LOGL_DEBUG, "Batch is full for RTP " - "ssrc=%u\n", rtph->ssrc); + LOGP(DLMUX, LOGL_DEBUG, "Batch is full for RTP sssrc=%u\n", rtph->ssrc); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2bb0ecf4cc165b9a1080e2558b33ba37014278c Gerrit-Change-Number: 15673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...libosmo-netif[master]: osmux: squash LOGP message to one line
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15673 Change subject: osmux: squash LOGP message to one line .. osmux: squash LOGP message to one line It seems different compiler versions (jenkins and my workstation) are generating different line number for that message, and it makes osmux_test fail when improving logging on next commit. Change-Id: Ie2bb0ecf4cc165b9a1080e2558b33ba37014278c --- M src/osmux.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/73/15673/1 diff --git a/src/osmux.c b/src/osmux.c index 9d058b0..c43c3eb 100644 --- a/src/osmux.c +++ b/src/osmux.c @@ -366,8 +366,7 @@ if (rtph == NULL) return -1; - LOGP(DLMUX, LOGL_DEBUG, "Batch is full for RTP " - "ssrc=%u\n", rtph->ssrc); + LOGP(DLMUX, LOGL_DEBUG, "Batch is full for RTP sssrc=%u\n", rtph->ssrc); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2bb0ecf4cc165b9a1080e2558b33ba37014278c Gerrit-Change-Number: 15673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange