Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-06 Thread pespin 
pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 )

Change subject: ss7: Do not queue messages if stream is not connected
..

ss7: Do not queue messages if stream is not connected

Consider them as lost by the lower layer, otherwise lots of old messages
and retransmissions can end up queued in there until stream becomes
connected, and then will flood the peer with all those messages.

Depends: libosmo-netif.git 962bf9a48eed418354685dc733b8271d2dd62c27
Related: OS#4188
Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
---
M src/osmo_ss7.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index e8a6918..053feca 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1810,6 +1810,11 @@
msgb_free(msg);
return -EIO;
}
+   if (!osmo_stream_cli_is_connected(asp->client)) {
+   LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, 
asp->client not connected\n");
+   msgb_free(msg);
+   return -EIO;
+   }
osmo_stream_cli_send(asp->client, msg);
}


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-06 Thread daniel 
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 )

Change subject: ss7: Do not queue messages if stream is not connected
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 06 Sep 2019 07:05:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-05 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 )

Change subject: ss7: Do not queue messages if stream is not connected
..


Patch Set 1:

Expected failure since dependent libosmo-netif patch is still not merged.


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 05 Sep 2019 09:41:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 )

Change subject: ss7: Do not queue messages if stream is not connected
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 04 Sep 2019 18:51:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

2019-09-04 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15405


Change subject: ss7: Do not queue messages if stream is not connected
..

ss7: Do not queue messages if stream is not connected

Consider them as lost by the lower layer, otherwise lots of old messages
and retransmissions can end up queued in there until stream becomes
connected, and then will flood the peer with all those messages.

Depends: libosmo-netif.git 962bf9a48eed418354685dc733b8271d2dd62c27
Related: OS#4188
Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
---
M src/osmo_ss7.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/05/15405/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index e8a6918..053feca 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1810,6 +1810,11 @@
msgb_free(msg);
return -EIO;
}
+   if (!osmo_stream_cli_is_connected(asp->client)) {
+   LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, 
asp->client not connected\n");
+   msgb_free(msg);
+   return -EIO;
+   }
osmo_stream_cli_send(asp->client, msg);
}


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange