Change in ...libosmocore[master]: (minor) fix typo in comments
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14442 ) Change subject: (minor) fix typo in comments .. (minor) fix typo in comments Change-Id: I697af428a2ea9a0ccd3f04ba8ec4664935ae29f8 --- M include/osmocom/core/utils.h 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 0673444..601bb56 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -48,7 +48,7 @@ int get_string_value(const struct value_string *vs, const char *str); char osmo_bcd2char(uint8_t bcd); -/* only works for numbers in ascci */ +/* only works for numbers in ASCII */ uint8_t osmo_char2bcd(char c); int osmo_bcd2str(char *dst, size_t dst_size, const uint8_t *bcd, int start_nibble, int end_nibble, bool allow_hex); @@ -92,7 +92,7 @@ rem -= ret; \ } while (0) -/*! Helper macro to terminate when an assertion failes +/*! Helper macro to terminate when an assertion fails * \param[in] exp Predicate to verify * This function will generate a backtrace and terminate the program if * the predicate evaluates to false (0). @@ -105,7 +105,7 @@ /*! duplicate a string using talloc and release its prior content (if any) * \param[in] ctx Talloc context to use for allocation * \param[out] dst pointer to string, will be updated with ptr to new string - * \param[in] newstr String that will be copieed to newly allocated string */ + * \param[in] newstr String that will be copied to newly allocated string */ static inline void osmo_talloc_replace_string(void *ctx, char **dst, const char *newstr) { if (*dst) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I697af428a2ea9a0ccd3f04ba8ec4664935ae29f8 Gerrit-Change-Number: 14442 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...libosmocore[master]: (minor) fix typo in comments
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14442 ) Change subject: (minor) fix typo in comments .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I697af428a2ea9a0ccd3f04ba8ec4664935ae29f8 Gerrit-Change-Number: 14442 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 13 Jun 2019 16:19:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: (minor) fix typo in comments
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14442 Change subject: (minor) fix typo in comments .. (minor) fix typo in comments Change-Id: I697af428a2ea9a0ccd3f04ba8ec4664935ae29f8 --- M include/osmocom/core/utils.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/14442/1 diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 0673444..601bb56 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -48,7 +48,7 @@ int get_string_value(const struct value_string *vs, const char *str); char osmo_bcd2char(uint8_t bcd); -/* only works for numbers in ascci */ +/* only works for numbers in ASCII */ uint8_t osmo_char2bcd(char c); int osmo_bcd2str(char *dst, size_t dst_size, const uint8_t *bcd, int start_nibble, int end_nibble, bool allow_hex); @@ -92,7 +92,7 @@ rem -= ret; \ } while (0) -/*! Helper macro to terminate when an assertion failes +/*! Helper macro to terminate when an assertion fails * \param[in] exp Predicate to verify * This function will generate a backtrace and terminate the program if * the predicate evaluates to false (0). @@ -105,7 +105,7 @@ /*! duplicate a string using talloc and release its prior content (if any) * \param[in] ctx Talloc context to use for allocation * \param[out] dst pointer to string, will be updated with ptr to new string - * \param[in] newstr String that will be copieed to newly allocated string */ + * \param[in] newstr String that will be copied to newly allocated string */ static inline void osmo_talloc_replace_string(void *ctx, char **dst, const char *newstr) { if (*dst) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I697af428a2ea9a0ccd3f04ba8ec4664935ae29f8 Gerrit-Change-Number: 14442 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon Gerrit-MessageType: newchange