Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-09 Thread fixeria 
fixeria has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15710 )

Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach()
..

L1SAP: do not pass unused parameter to l1sap_handover_rach()

Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 54953b0..93a70cd 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1288,8 +1288,7 @@
 }

 /* Special case where handover RACH is detected */
-static int l1sap_handover_rach(struct gsm_bts_trx *trx,
-   struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
+static int l1sap_handover_rach(struct gsm_bts_trx *trx, struct 
ph_rach_ind_param *rach_ind)
 {
/* Filter out noise / interference / ghosts */
if (!rach_pass_filter(rach_ind, trx->bts)) {
@@ -1330,7 +1329,7 @@
/* check for handover access burst on dedicated channels */
if (!L1SAP_IS_CHAN_RACH(rach_ind->chan_nr)) {
rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_HO);
-   return l1sap_handover_rach(trx, l1sap, rach_ind);
+   return l1sap_handover_rach(trx, rach_ind);
}

rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_RCVD);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
Gerrit-Change-Number: 15710
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15710 )

Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
Gerrit-Change-Number: 15710
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:59:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-08 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15710 )

Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
Gerrit-Change-Number: 15710
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 08 Oct 2019 20:27:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: do not pass unused parameter to l1sap_handover_rach()

2019-10-08 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15710


Change subject: L1SAP: do not pass unused parameter to l1sap_handover_rach()
..

L1SAP: do not pass unused parameter to l1sap_handover_rach()

Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/10/15710/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 54953b0..93a70cd 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1288,8 +1288,7 @@
 }

 /* Special case where handover RACH is detected */
-static int l1sap_handover_rach(struct gsm_bts_trx *trx,
-   struct osmo_phsap_prim *l1sap, struct ph_rach_ind_param *rach_ind)
+static int l1sap_handover_rach(struct gsm_bts_trx *trx, struct 
ph_rach_ind_param *rach_ind)
 {
/* Filter out noise / interference / ghosts */
if (!rach_pass_filter(rach_ind, trx->bts)) {
@@ -1330,7 +1329,7 @@
/* check for handover access burst on dedicated channels */
if (!L1SAP_IS_CHAN_RACH(rach_ind->chan_nr)) {
rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_HO);
-   return l1sap_handover_rach(trx, l1sap, rach_ind);
+   return l1sap_handover_rach(trx, rach_ind);
}

rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_RCVD);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f2d909f1bde09cbec106240df290381b3418e46
Gerrit-Change-Number: 15710
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange