Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-09 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15714 )

Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
..

L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
---
M src/common/l1sap.c
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 0696fab..7d403f0 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -333,13 +333,6 @@
if (L1SAP_IS_PTCCH(fn)) {
*chan_type = GSMTAP_CHANNEL_PTCCH;
*ss = L1SAP_FN2PTCCHBLOCK(fn);
-   if (l1sap->oph.primitive == PRIM_OP_INDICATION) {
-   OSMO_ASSERT(len > 0);
-   if ((*data[0]) == 7)
-   return -EINVAL;
-   (*data)++;
-   (*len)--;
-   }
} else
*chan_type = GSMTAP_CHANNEL_PACCH;


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-09 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15714 )

Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 16:44:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-09 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15714 )

Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
..


Patch Set 1:

> Ok, I just realized there is no need to pass this one anymore.

Actually, needed.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 12:20:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15714 )

Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:08:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

2019-10-08 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15714


Change subject: L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U
..

L1SAP: fix gsmtap_pdch(): there can be no DATA.ind on PTCCH/U

Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
---
M src/common/l1sap.c
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/14/15714/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 0696fab..7d403f0 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -333,13 +333,6 @@
if (L1SAP_IS_PTCCH(fn)) {
*chan_type = GSMTAP_CHANNEL_PTCCH;
*ss = L1SAP_FN2PTCCHBLOCK(fn);
-   if (l1sap->oph.primitive == PRIM_OP_INDICATION) {
-   OSMO_ASSERT(len > 0);
-   if ((*data[0]) == 7)
-   return -EINVAL;
-   (*data)++;
-   (*len)--;
-   }
} else
*chan_type = GSMTAP_CHANNEL_PACCH;


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15714
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id69010ffa8c697e8c01bbb21509253c330f95343
Gerrit-Change-Number: 15714
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange