Change in ...osmo-bts[master]: L1SAP: use the actual ARFCN for outgoing PCUIF messages

2019-10-09 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15713 )

Change subject: L1SAP: use the actual ARFCN for outgoing PCUIF messages
..

L1SAP: use the actual ARFCN for outgoing PCUIF messages

Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 67d569b..0696fab 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -802,10 +802,10 @@
} else {
/* forward RTS.ind to PCU */
if (L1SAP_IS_PTCCH(rts_ind->fn)) {
-   pcu_tx_rts_req(>ts[tn], 1, fn, 1 /* ARFCN 
*/,
+   pcu_tx_rts_req(>ts[tn], 1, fn, trx->arfcn,
L1SAP_FN2PTCCHBLOCK(fn));
} else {
-   pcu_tx_rts_req(>ts[tn], 0, fn, 0 /* ARFCN 
*/,
+   pcu_tx_rts_req(>ts[tn], 0, fn, trx->arfcn,
L1SAP_FN2MACBLOCK(fn));
}
/* return early, PCU takes care of rest */
@@ -1135,7 +1135,7 @@
return -EINVAL;
if (L1SAP_IS_PTCCH(fn)) {
pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PTCCH, fn,
-   0 /* ARFCN */, L1SAP_FN2PTCCHBLOCK(fn),
+   trx->arfcn, L1SAP_FN2PTCCHBLOCK(fn),
data, len, rssi, data_ind->ber10k,
data_ind->ta_offs_256bits/64,
data_ind->lqual_cb);
@@ -1144,7 +1144,7 @@
if (pr_info != PRES_INFO_BOTH)
return 0;
/* PDTCH / PACCH frame handling */
-   pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PDTCH, fn, 0 
/* ARFCN */,
+   pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PDTCH, fn, 
trx->arfcn,
L1SAP_FN2MACBLOCK(fn), data, len, rssi, 
data_ind->ber10k,
data_ind->ta_offs_256bits/64, 
data_ind->lqual_cb);
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15713
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
Gerrit-Change-Number: 15713
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-bts[master]: L1SAP: use the actual ARFCN for outgoing PCUIF messages

2019-10-09 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15713 )

Change subject: L1SAP: use the actual ARFCN for outgoing PCUIF messages
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15713
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
Gerrit-Change-Number: 15713
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 16:44:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: use the actual ARFCN for outgoing PCUIF messages

2019-10-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15713 )

Change subject: L1SAP: use the actual ARFCN for outgoing PCUIF messages
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15713
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
Gerrit-Change-Number: 15713
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:07:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: L1SAP: use the actual ARFCN for outgoing PCUIF messages

2019-10-08 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15713


Change subject: L1SAP: use the actual ARFCN for outgoing PCUIF messages
..

L1SAP: use the actual ARFCN for outgoing PCUIF messages

Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/15713/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 67d569b..0696fab 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -802,10 +802,10 @@
} else {
/* forward RTS.ind to PCU */
if (L1SAP_IS_PTCCH(rts_ind->fn)) {
-   pcu_tx_rts_req(>ts[tn], 1, fn, 1 /* ARFCN 
*/,
+   pcu_tx_rts_req(>ts[tn], 1, fn, trx->arfcn,
L1SAP_FN2PTCCHBLOCK(fn));
} else {
-   pcu_tx_rts_req(>ts[tn], 0, fn, 0 /* ARFCN 
*/,
+   pcu_tx_rts_req(>ts[tn], 0, fn, trx->arfcn,
L1SAP_FN2MACBLOCK(fn));
}
/* return early, PCU takes care of rest */
@@ -1135,7 +1135,7 @@
return -EINVAL;
if (L1SAP_IS_PTCCH(fn)) {
pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PTCCH, fn,
-   0 /* ARFCN */, L1SAP_FN2PTCCHBLOCK(fn),
+   trx->arfcn, L1SAP_FN2PTCCHBLOCK(fn),
data, len, rssi, data_ind->ber10k,
data_ind->ta_offs_256bits/64,
data_ind->lqual_cb);
@@ -1144,7 +1144,7 @@
if (pr_info != PRES_INFO_BOTH)
return 0;
/* PDTCH / PACCH frame handling */
-   pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PDTCH, fn, 0 
/* ARFCN */,
+   pcu_tx_data_ind(>ts[tn], PCU_IF_SAPI_PDTCH, fn, 
trx->arfcn,
L1SAP_FN2MACBLOCK(fn), data, len, rssi, 
data_ind->ber10k,
data_ind->ta_offs_256bits/64, 
data_ind->lqual_cb);
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15713
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07b3aac97603d85fb6cf077d3a342b12b0643171
Gerrit-Change-Number: 15713
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange