Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-19 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537 )

Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..


Patch Set 2:

fixeria: it started sending them with this patch: 
https://git.osmocom.org/osmo-trx/commit/?id=4e6ec4554da612eaf04339fe515a77535a104302


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 19 Sep 2019 10:09:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-19 Thread pespin
pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537 )

Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..

bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

It's impossible to see other logging otherwise.

Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 6c6d5ad..166cfe6 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -1007,7 +1007,7 @@
 * TDMA frames, and properly drive scheduler if nothing has been
 * detected on non-IDLE channels. */
if (bi.flags & TRX_BI_F_NOPE_IND) {
-   LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE,
+   LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
"IDLE / NOPE indications are not (yet) supported\n");
return -ENOTSUP;
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-19 Thread osmith
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537 )

Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 19 Sep 2019 07:48:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537 )

Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..


Patch Set 1: Code-Review+2

Huh, so OsmoTRX somehow started to send them, and it did not before? o_O


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 18 Sep 2019 20:22:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-16 Thread pespin
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537


Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..

bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

It's impossible to see other logging otherwise.

Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/37/15537/1

diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 6c6d5ad..166cfe6 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -1007,7 +1007,7 @@
 * TDMA frames, and properly drive scheduler if nothing has been
 * detected on non-IDLE channels. */
if (bi.flags & TRX_BI_F_NOPE_IND) {
-   LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE,
+   LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
"IDLE / NOPE indications are not (yet) supported\n");
return -ENOTSUP;
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange