Change in ...osmo-msc[master]: libvlr/vlr.c: cosmetic: move message_type assignment

2019-08-18 Thread fixeria 
fixeria has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15226 )

Change subject: libvlr/vlr.c: cosmetic: move message_type assignment
..

libvlr/vlr.c: cosmetic: move message_type assignment

Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
---
M src/libvlr/vlr.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 625b699..de61ba5 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -680,6 +680,7 @@
 {
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+   .message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST,
};
uint8_t imei_enc[GSM23003_IMEI_NUM_DIGITS+2]; /* +2: IE header */
int len;
@@ -694,7 +695,6 @@
gsup_msg.imei_enc_len = len;

/* Send CHECK_IMEI_REQUEST */
-   gsup_msg.message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
 }
@@ -704,9 +704,9 @@
 {
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+   .message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT,
};

-   gsup_msg.message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15226
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
Gerrit-Change-Number: 15226
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-msc[master]: libvlr/vlr.c: cosmetic: move message_type assignment

2019-08-18 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15226 )

Change subject: libvlr/vlr.c: cosmetic: move message_type assignment
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15226
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
Gerrit-Change-Number: 15226
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sun, 18 Aug 2019 11:11:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: libvlr/vlr.c: cosmetic: move message_type assignment

2019-08-16 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15226 )

Change subject: libvlr/vlr.c: cosmetic: move message_type assignment
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15226
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
Gerrit-Change-Number: 15226
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 16 Aug 2019 10:12:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: libvlr/vlr.c: cosmetic: move message_type assignment

2019-08-15 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15226


Change subject: libvlr/vlr.c: cosmetic: move message_type assignment
..

libvlr/vlr.c: cosmetic: move message_type assignment

Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
---
M src/libvlr/vlr.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/15226/1

diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 625b699..de61ba5 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -680,6 +680,7 @@
 {
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+   .message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST,
};
uint8_t imei_enc[GSM23003_IMEI_NUM_DIGITS+2]; /* +2: IE header */
int len;
@@ -694,7 +695,6 @@
gsup_msg.imei_enc_len = len;

/* Send CHECK_IMEI_REQUEST */
-   gsup_msg.message_type = OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
 }
@@ -704,9 +704,9 @@
 {
struct osmo_gsup_message gsup_msg = {
.message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT,
+   .message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT,
};

-   gsup_msg.message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT;
OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return gsup_client_mux_tx(vsub->vlr->gcm, _msg);
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15226
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f98597b54f03069375fac56fb162f2669e7f0
Gerrit-Change-Number: 15226
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange