Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. Patch Set 2: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 Gerrit-Change-Number: 15565 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 19 Sep 2019 07:46:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 Gerrit-Change-Number: 15565 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 18 Sep 2019 17:51:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 Gerrit-Change-Number: 15565 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 18 Sep 2019 13:52:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. configure.ac: set C and C++ dialects Make sure that the compiler always assumes the same C dialect, to prevent unexpected compiler errors when building with older compilers (on other Linux distrubtions like in OBS, or in docker). Use gnu89 and gnu++03, because that is what the code currently compiles with. Related: https://lists.osmocom.org/pipermail/openbsc/2019-September/013030.html Related: OS#3598 Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/15565/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 Gerrit-Change-Number: 15565 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset
Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 Change subject: configure.ac: set C and C++ dialects .. configure.ac: set C and C++ dialects Make sure that the compiler always assumes the same C dialect, to prevent unexpected compiler errors when building with older compilers (on other Linux distrubtions like in OBS, or in docker). Use gnu89 and gnu++03, because that is what the code currently compiles with. Related: OS#3598 Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/15565/1 diff --git a/configure.ac b/configure.ac index 5ecd133..2f29047 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,9 @@ AM_INIT_AUTOMAKE([dist-bzip2]) AC_CONFIG_TESTDIR(tests) +CXXFLAGS="$CXXFLAGS -std=gnu++03" +CFLAGS="$CFLAGS -std=gnu89" + dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia57ba101627e3cc0babeca82631e207a3e2e0960 Gerrit-Change-Number: 15565 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
