Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-13 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default configs
..

osmo-remsim-client: add systemd service script template and etc/default configs

Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
---
A contrib/etc_default/osmo-remsim-client
A contrib/etc_default/osmo-remsim-client-0
A contrib/etc_default/osmo-remsim-client-1
A contrib/etc_default/osmo-remsim-client-2
A contrib/etc_default/osmo-remsim-client-3
A contrib/systemd/osmo-remsim-client@.service
6 files changed, 42 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/etc_default/osmo-remsim-client 
b/contrib/etc_default/osmo-remsim-client
new file mode 100644
index 000..b1a2187
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client
@@ -0,0 +1,4 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# Options to pass to osmo-remsim-client
+GLOBAL_CLIENT_OPTS="-s 10.9.99.10 -V 1d50 -P 4004 -C 1"
diff --git a/contrib/etc_default/osmo-remsim-client-0 
b/contrib/etc_default/osmo-remsim-client-0
new file mode 100644
index 000..8b70721
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client-0
@@ -0,0 +1,6 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# Options to pass to osmo-remsim-client
+REMSIM_I="0"
+REMSIM_H="2-1.1"
+REMSIM_c="0"
diff --git a/contrib/etc_default/osmo-remsim-client-1 
b/contrib/etc_default/osmo-remsim-client-1
new file mode 100644
index 000..519dcb4
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client-1
@@ -0,0 +1,6 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# Options to pass to osmo-remsim-client
+REMSIM_I="1"
+REMSIM_H="2-1.1"
+REMSIM_c="0"
diff --git a/contrib/etc_default/osmo-remsim-client-2 
b/contrib/etc_default/osmo-remsim-client-2
new file mode 100644
index 000..3f66289
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client-2
@@ -0,0 +1,6 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# Options to pass to osmo-remsim-client
+REMSIM_I="0"
+REMSIM_H="2-1.4"
+REMSIM_c="0"
diff --git a/contrib/etc_default/osmo-remsim-client-3 
b/contrib/etc_default/osmo-remsim-client-3
new file mode 100644
index 000..149af2b
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client-3
@@ -0,0 +1,6 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# Options to pass to osmo-remsim-client
+REMSIM_I="1"
+REMSIM_H="2-1.4"
+REMSIM_c="0"
diff --git a/contrib/systemd/osmo-remsim-client@.service 
b/contrib/systemd/osmo-remsim-client@.service
new file mode 100644
index 000..738ae4a
--- /dev/null
+++ b/contrib/systemd/osmo-remsim-client@.service
@@ -0,0 +1,14 @@
+[Unit]
+Description=Osmocom Remote SIM Client %i
+
+[Service]
+Type=simple
+Restart=always
+EnvironmentFile=/etc/default/osmo-remsim-client
+EnvironmentFile=/etc/default/osmo-remsim-client-%i
+ExecStart=/usr/bin/osmo-remsim-client-st2 $GLOBAL_CLIENT_OPTS -I $REMSIM_I -H 
$REMSIM_H -c $REMSIM_c
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
+

--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 3
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: roh 
Gerrit-MessageType: merged

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-12 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default configs
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 2
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: roh 
Gerrit-Comment-Date: Wed, 12 Jun 2019 22:00:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-12 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default configs
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 2
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: roh 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Wed, 12 Jun 2019 20:17:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-12 Thread roh 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-remsim/+/14267

to look at the new patch set (#2).

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default configs
..

osmo-remsim-client: add systemd service script template and etc/default configs

Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
---
A contrib/etc_default/osmo-remsim-client
A contrib/etc_default/osmo-remsim-client-0
A contrib/etc_default/osmo-remsim-client-1
A contrib/etc_default/osmo-remsim-client-2
A contrib/etc_default/osmo-remsim-client-3
A contrib/systemd/osmo-remsim-client@.service
6 files changed, 42 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/67/14267/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 2
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh 
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default config
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service
File contrib/systemd/osmo-remsim-client_.service:

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service@8
PS1, Line 8: 2-1.1
> yes - but this is a template to be copied n (number of modems) times and 
> modified to fit the specifi […]
So if I understand correctly, you need to change several parameters per process 
instance launched and not only the "2-1.1" part, right?

What about using: EnvironmentFile=/etc/default/osmo-remsim-client-%i
And then have /etc/default/osmo-remsim-client-{0..N} files, each defining env 
variables with different values?
For instance, /etc/default/osmo-remsim-client-0:
REMSIM_H="2-1.1"
REMSIM_C="0"

and then in this sytemd template:
EnvironmentFile=/etc/default/osmo-remsim-client-%i
ExecStart=/usr/bin/osmo-remsim-client-st2 $CLIENT_OPTS -I 0 -H $REMSIM_H -c 
$REMSIM_C



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 1
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh 
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 11 Jun 2019 16:46:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: roh 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default config
..


Patch Set 1:

assigning to pespin, whom I believe to know more systemd voodoo


--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 1
Gerrit-Owner: roh 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh 
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 11 Jun 2019 14:57:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread roh 
roh has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default config
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service
 
File contrib/systemd/osmo-remsim-client_.service:

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service@8
PS1, Line 8: 2-1.1
> wouldn't that mandate that it is attached at a certain position in the bus?
yes - but this is a template to be copied n (number of modems) times and 
modified to fit the specific modem served.
i am open to better ideas for iterators of this than hardcoding it in config



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 1
Gerrit-Owner: roh 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: roh 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 11 Jun 2019 14:30:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-05-29 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/14267 )

Change subject: osmo-remsim-client: add systemd service script template and 
etc/default config
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service
File contrib/systemd/osmo-remsim-client_.service:

https://gerrit.osmocom.org/#/c/14267/1/contrib/systemd/osmo-remsim-client_.service@8
PS1, Line 8: 2-1.1
wouldn't that mandate that it is attached at a certain position in the bus?



--
To view, visit https://gerrit.osmocom.org/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 1
Gerrit-Owner: roh 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 29 May 2019 18:24:44 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-05-29 Thread roh 
roh has uploaded this change for review. ( https://gerrit.osmocom.org/14267


Change subject: osmo-remsim-client: add systemd service script template and 
etc/default config
..

osmo-remsim-client: add systemd service script template and etc/default config

Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
---
A contrib/etc_default/osmo-remsim-client
A contrib/systemd/osmo-remsim-client_.service
2 files changed, 18 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/67/14267/1

diff --git a/contrib/etc_default/osmo-remsim-client 
b/contrib/etc_default/osmo-remsim-client
new file mode 100644
index 000..23621de
--- /dev/null
+++ b/contrib/etc_default/osmo-remsim-client
@@ -0,0 +1,5 @@
+# Default settings for osmo-remsim-client This file is sourced by systemd
+
+# (global) Options to pass to osmo-remsim-client
+CLIENT_OPTS="-s 10.9.99.10 -V 1d50 -P 4004 -C 1"
+
diff --git a/contrib/systemd/osmo-remsim-client_.service 
b/contrib/systemd/osmo-remsim-client_.service
new file mode 100644
index 000..e7129c2
--- /dev/null
+++ b/contrib/systemd/osmo-remsim-client_.service
@@ -0,0 +1,13 @@
+[Unit]
+Description=Osmocom Remote SIM Client
+
+[Service]
+Type=simple
+Restart=always
+EnvironmentFile=/etc/default/osmo-remsim-client
+ExecStart=/usr/bin/osmo-remsim-client-st2 $CLIENT_OPTS -I 0 -H 2-1.1 -c 0
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
+

--
To view, visit https://gerrit.osmocom.org/14267
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I243f3d8e090d49ca3a1d0a8cf568750b76273c03
Gerrit-Change-Number: 14267
Gerrit-PatchSet: 1
Gerrit-Owner: roh