Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_IDLE
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 ) Change subject: sgsn: Gb: implementing PS Paging when MS is MM_IDLE .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15705/3/src/sgsn/sgsn_libgtp.c File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/#/c/15705/3/src/sgsn/sgsn_libgtp.c@670 PS3, Line 670: You are missing here the following: " FIXME: queue the packet we received from GTP */" -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 08 Oct 2019 16:13:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_IDLE
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 to look at the new patch set (#3). Change subject: sgsn: Gb: implementing PS Paging when MS is MM_IDLE .. sgsn: Gb: implementing PS Paging when MS is MM_IDLE When the MS is in MM_IDLE, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/15705/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: sgsn: Gb: implementing PS Paging when MS is MM_IDLE
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 Change subject: sgsn: Gb: implementing PS Paging when MS is MM_IDLE .. sgsn: Gb: implementing PS Paging when MS is MM_IDLE When the MS is in MM_IDLE, the Routing Area is known, but not the exact cell. Start the paging procedure. (Even this is only supported for the last known cell, not the Routing Area. Routing Area paging is not yet supported.) Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/05/15705/1 diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 496079a..73b71c3 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -54,6 +54,7 @@ #include #include #include +#include #include #include @@ -664,6 +665,9 @@ /* FIXME: queue the packet we received from GTP */ break; case ST_GMM_REGISTERED_NORMAL: + if (mm->gb.mm_state_fsm->state == ST_MM_IDLE) + gprs_gb_page_ps_cell(mm); + break; default: LOGP(DGPRS, LOGL_ERROR, "GTP DATA IND for TLLI %08X in state " -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc2c6ba70f8f74054546a1e31741fc90b232a23c Gerrit-Change-Number: 15705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange
