Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

2019-10-08 Thread lynxis lazus 
lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15553 )

Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
..

sgsn: MM Gb Fsm: fix event handling for implicit detach

Implicit detach means there won't be any Gb state afterwards.

Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
---
M src/sgsn/gprs_mm_state_gb_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c
index 02f6747..f6d680c 100644
--- a/src/sgsn/gprs_mm_state_gb_fsm.c
+++ b/src/sgsn/gprs_mm_state_gb_fsm.c
@@ -47,9 +47,11 @@

switch(event) {
case E_MM_READY_TIMER_EXPIRY:
-   case E_MM_IMPLICIT_DETACH:
mm_state_gb_fsm_state_chg(fi, ST_MM_STANDBY);
break;
+   case E_MM_IMPLICIT_DETACH:
+   mm_state_gb_fsm_state_chg(fi, ST_MM_IDLE);
+   break;
case E_MM_PDU_RECEPTION:
/* RE-arm the READY timer upon receival of Gb PDUs */
t_secs = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1);

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

2019-09-29 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15553 )

Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sun, 29 Sep 2019 18:09:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

2019-09-28 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15553 )

Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Sat, 28 Sep 2019 21:02:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

2019-09-17 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15553 )

Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 17 Sep 2019 17:53:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn: MM Gb Fsm: fix event handling for implicit detach

2019-09-17 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15553


Change subject: sgsn: MM Gb Fsm: fix event handling for implicit detach
..

sgsn: MM Gb Fsm: fix event handling for implicit detach

Implicit detach means there won't be any Gb state afterwards.

Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
---
M src/sgsn/gprs_mm_state_gb_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/53/15553/1

diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c
index 02f6747..f6d680c 100644
--- a/src/sgsn/gprs_mm_state_gb_fsm.c
+++ b/src/sgsn/gprs_mm_state_gb_fsm.c
@@ -47,9 +47,11 @@

switch(event) {
case E_MM_READY_TIMER_EXPIRY:
-   case E_MM_IMPLICIT_DETACH:
mm_state_gb_fsm_state_chg(fi, ST_MM_STANDBY);
break;
+   case E_MM_IMPLICIT_DETACH:
+   mm_state_gb_fsm_state_chg(fi, ST_MM_IDLE);
+   break;
case E_MM_PDU_RECEPTION:
/* RE-arm the READY timer upon receival of Gb PDUs */
t_secs = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1);

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iececb730e7135e14ebd94f82edb79b03ced1f9e3
Gerrit-Change-Number: 15553
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange