Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: abandon
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 )
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
Patch Set 4: Code-Review-1
Then the correct fix imho is to conditionally call f_ran_adapter_cleanup()
conditionally based on g_ranap_enable in f_cleanup():
function f_cleanup() runs on test_CT {
var integer i;
if (g_ranap_enable) {
for (i := 0; i < NUM_RNC; i := i+1) {
f_ran_adapter_cleanup(g_ranap[i]);
}
}
self.stop;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 10 Sep 2019 09:19:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG@10 PS4, Line 10: is not bound when Iu is disabled. > "Iu is disabled" means disabled by means of #ifef? then use a ifdef too to > conditionally call that p […] no. disabled by the testcase. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 10 Sep 2019 09:13:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG@10 PS4, Line 10: is not bound when Iu is disabled. > no. disabled by the testcase. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15162/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 10 Sep 2019 09:14:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15391/4//COMMIT_MSG@10 PS4, Line 10: is not bound when Iu is disabled. "Iu is disabled" means disabled by means of #ifef? then use a ifdef too to conditionally call that part. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 10 Sep 2019 09:12:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 to look at the new patch set (#4). Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound In preparation to make Iu support optional. The adapter is not bound when Iu is disabled. Change-Id: I9c974a850949829728c35cf5dbdd0858fdef --- M library/RAN_Adapter.ttcnpp 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/15391/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 10 Sep 2019 08:36:17 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 3: Code-Review-1 Don't merge it yet, I think lynxis wanted to retry about this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Sep 2019 19:08:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Sep 2019 18:51:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Hello pespin, laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
to look at the new patch set (#3).
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure. All test cases fail on my
machine because of an unbound reference object.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 2: I'm surprised about this patch. Which tests fail in your case? which testsuite? AFAIU this function is only called so far for SGSN_Tests and ba exists there, and tests pass in my setup and in jenkins. How can you call f_Ran_adapter_cleanup() with ba being unbound? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:39:49 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Hello pespin, laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
to look at the new patch set (#2).
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure. All test cases fail on my
machine because of an unbound reference object.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/1
diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index f84fd34..aed31ed 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -191,6 +191,10 @@
}
function f_ran_adapter_cleanup(inout RAN_Adapter ba) {
+ if (not isbound(ba)) {
+ return;
+ }
+
if (ba.vc_RAN != null) {
if (ba.transport == RANAP_TRANSPORT_IuCS) {
#ifdef RAN_EMULATION_RANAP
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
