Change in ...osmo-ttcn3-hacks[master]: Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

2019-09-16 Thread lynxis lazus
lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530 )

Change subject: Require to receive RANAP_CommonId after 
RANAP_SecurityModeComplete
..

Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

The SGSN will send a CommonId after it has sent SecurityModeComplete
to support paging coordination in the RNC.

Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index d96767a..281dcc9 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -661,6 +661,7 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 
0; /* 0 = standard_UMTS_integrity_algorithm_UIA1 */

BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
+   
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)))
}
}
} else {
@@ -2397,6 +2398,7 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 0; /* 0 
= standard_UMTS_integrity_algorithm_UIA1 */
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
+   
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)))
}
[is_gb(ran_index)] BSSGP[ran_index].receive { repeat; }
[is_iu(ran_index)] BSSAP.receive { repeat; }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in ...osmo-ttcn3-hacks[master]: Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

2019-09-16 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530 )

Change subject: Require to receive RANAP_CommonId after 
RANAP_SecurityModeComplete
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:39:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in ...osmo-ttcn3-hacks[master]: Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

2019-09-15 Thread lynxis lazus
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530

to look at the new patch set (#2).

Change subject: Require to receive RANAP_CommonId after 
RANAP_SecurityModeComplete
..

Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

The SGSN will send a CommonId after it has sent SecurityModeComplete
to support paging coordination in the RNC.

Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/30/15530/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset