Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

2019-09-09 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455 )

Change subject: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in 
tr_IMM_ASS
..

library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
---
M library/GSM_RR_Types.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index b098118..49ceae3 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -756,7 +756,7 @@
 template TimingAdvance ta := ?,
 template ChannelDescription ch_desc := 
?,
 template MobileAllocation ma := ?) := {
-   header := t_RrHeader(IMMEDIATE_ASSIGNMENT, 0),
+   header := t_RrHeader(IMMEDIATE_ASSIGNMENT, ?),
payload := {
imm_ass := {
ded_or_tbf := {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

2019-09-09 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455 )

Change subject: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in 
tr_IMM_ASS
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:48:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

2019-09-09 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455 )

Change subject: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in 
tr_IMM_ASS
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 09 Sep 2019 18:14:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

2019-09-09 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455


Change subject: library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in 
tr_IMM_ASS
..

library/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASS

Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
---
M library/GSM_RR_Types.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/55/15455/1

diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index b098118..49ceae3 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -756,7 +756,7 @@
 template TimingAdvance ta := ?,
 template ChannelDescription ch_desc := 
?,
 template MobileAllocation ma := ?) := {
-   header := t_RrHeader(IMMEDIATE_ASSIGNMENT, 0),
+   header := t_RrHeader(IMMEDIATE_ASSIGNMENT, ?),
payload := {
imm_ass := {
ded_or_tbf := {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15455
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
Gerrit-Change-Number: 15455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange