Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 ) Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9 Gerrit-Change-Number: 14372 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte Gerrit-MessageType: abandon
Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 )
Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of
messages
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn
File library/TRXC_CodecPort.ttcn:
https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn@31
PS2, Line 31: log("Rx TRXC message: ", oct2char(pin.msg));
> doesn't the IPL4asp_PT log that by itself? Or, if it doesn't, can't we
> simply enable related loggin […]
As far as this issue is concerned the existing logging was sufficient - it was
just not obvious that it arrived at the wrong port. I don't think this change
is necessary.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
Gerrit-Change-Number: 14372
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:46:46 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Harald Welte
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 )
Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of
messages
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn
File library/TRXC_CodecPort.ttcn:
https://gerrit.osmocom.org/#/c/14372/2/library/TRXC_CodecPort.ttcn@31
PS2, Line 31: log("Rx TRXC message: ", oct2char(pin.msg));
doesn't the IPL4asp_PT log that by itself? Or, if it doesn't, can't we simply
enable related logging of it by tuning the logging parameters? This looks like
something that we shouldn't [have to] do by hand.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
Gerrit-Change-Number: 14372
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte
Gerrit-Comment-Date: Tue, 04 Jun 2019 15:23:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 to look at the new patch set (#2). Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages .. library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9 --- M library/TRXC_CodecPort.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/14372/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9 Gerrit-Change-Number: 14372 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of
messages
..
library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages
Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
---
M library/TRXC_CodecPort.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/72/14372/1
diff --git a/library/TRXC_CodecPort.ttcn b/library/TRXC_CodecPort.ttcn
index 09b2977..7dee369 100644
--- a/library/TRXC_CodecPort.ttcn
+++ b/library/TRXC_CodecPort.ttcn
@@ -28,6 +28,7 @@
}
private function IPL4_to_TRXC_RecvFrom(in ASP_RecvFrom pin, out TRXC_RecvFrom
pout) {
+ log("Rx TRXC message: ", oct2char(pin.msg));
pout.connId := pin.connId;
pout.remName := pin.remName;
pout.remPort := pin.remPort;
@@ -73,6 +74,7 @@
}
};
}
+ log("Tx TRXC message: ", tx);
pt.send(ts_TRXC_Send(conn_id, tx));
T.start;
alt {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I04af0043c67c5904d034b60b39ddce44aa4beba9
Gerrit-Change-Number: 14372
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
