Change in ...simtrace2[master]: disable ERASE pin
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15168 ) Change subject: disable ERASE pin .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/15168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic3332eb1d4247a07988b2fd841f40e79862d06a7 Gerrit-Change-Number: 15168 Gerrit-PatchSet: 1 Gerrit-Owner: tsaitgaist Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 13 Aug 2019 10:55:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...simtrace2[master]: disable ERASE pin
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/15168 ) Change subject: disable ERASE pin .. disable ERASE pin disabling the ERASE pin prevents accidental erase for the flash memory while the board is powered on (e.g. in case the user overcomes the weak 100 kOhm pull-down for more than 220 ms by touching or shorting the pin). the flash is still erasable using the ERASE pin during power up. it is only disabled after boot completed. Change-Id: Ic3332eb1d4247a07988b2fd841f40e79862d06a7 --- M firmware/libboard/common/source/board_lowlevel.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/libboard/common/source/board_lowlevel.c b/firmware/libboard/common/source/board_lowlevel.c index 8210938..b4d7d32 100644 --- a/firmware/libboard/common/source/board_lowlevel.c +++ b/firmware/libboard/common/source/board_lowlevel.c @@ -127,6 +127,9 @@ SUPC->SUPC_SMMR = SUPC_SMMR_SMTH_3_0V | SUPC_SMMR_SMSMPL_CSM | SUPC_SMMR_SMRSTEN_ENABLE; + /* disable ERASE pin to prevent accidental flash erase */ + MATRIX->CCFG_SYSIO |= CCFG_SYSIO_SYSIO12; + /* enable both LED and green LED */ PIOA->PIO_PER |= PIO_LED_RED | PIO_LED_GREEN; PIOA->PIO_OER |= PIO_LED_RED | PIO_LED_GREEN; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/15168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic3332eb1d4247a07988b2fd841f40e79862d06a7 Gerrit-Change-Number: 15168 Gerrit-PatchSet: 1 Gerrit-Owner: tsaitgaist Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...simtrace2[master]: disable ERASE pin
tsaitgaist has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/15168 Change subject: disable ERASE pin .. disable ERASE pin disabling the ERASE pin prevents accidental erase for the flash memory while the board is powered on (e.g. in case the user overcomes the weak 100 kOhm pull-down for more than 220 ms by touching or shorting the pin). the flash is still erasable using the ERASE pin during power up. it is only disabled after boot completed. Change-Id: Ic3332eb1d4247a07988b2fd841f40e79862d06a7 --- M firmware/libboard/common/source/board_lowlevel.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/68/15168/1 diff --git a/firmware/libboard/common/source/board_lowlevel.c b/firmware/libboard/common/source/board_lowlevel.c index 8210938..b4d7d32 100644 --- a/firmware/libboard/common/source/board_lowlevel.c +++ b/firmware/libboard/common/source/board_lowlevel.c @@ -127,6 +127,9 @@ SUPC->SUPC_SMMR = SUPC_SMMR_SMTH_3_0V | SUPC_SMMR_SMSMPL_CSM | SUPC_SMMR_SMRSTEN_ENABLE; + /* disable ERASE pin to prevent accidental flash erase */ + MATRIX->CCFG_SYSIO |= CCFG_SYSIO_SYSIO12; + /* enable both LED and green LED */ PIOA->PIO_PER |= PIO_LED_RED | PIO_LED_GREEN; PIOA->PIO_OER |= PIO_LED_RED | PIO_LED_GREEN; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/15168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic3332eb1d4247a07988b2fd841f40e79862d06a7 Gerrit-Change-Number: 15168 Gerrit-PatchSet: 1 Gerrit-Owner: tsaitgaist Gerrit-MessageType: newchange
