Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11364 ) Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. osmo-*-latest: s/nightly/latest/g in Dockerfile Follow up to I6a564206dd81743deb1eb27eca7081bc333d7434 where the "*-latest" Dockerfiles were introduced. msc, sgsn, sip, stp had references to "nightly" instead of "latest" in their Dockerfiles. Related: OS#3268 Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 --- M osmo-msc-latest/Dockerfile M osmo-sgsn-latest/Dockerfile M osmo-sip-latest/Dockerfile M osmo-stp-latest/Dockerfile 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Harald Welte: Looks good to me, approved Neels Hofmeyr: Looks good to me, approved osmith: Verified diff --git a/osmo-msc-latest/Dockerfile b/osmo-msc-latest/Dockerfile index 02298e7..a8cc3ba 100644 --- a/osmo-msc-latest/Dockerfile +++ b/osmo-msc-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ diff --git a/osmo-sgsn-latest/Dockerfile b/osmo-sgsn-latest/Dockerfile index 56b5fda..87dbca2 100644 --- a/osmo-sgsn-latest/Dockerfile +++ b/osmo-sgsn-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ diff --git a/osmo-sip-latest/Dockerfile b/osmo-sip-latest/Dockerfile index 9f978d8..a468c9f 100644 --- a/osmo-sip-latest/Dockerfile +++ b/osmo-sip-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key diff --git a/osmo-stp-latest/Dockerfile b/osmo-stp-latest/Dockerfile index f5920a5..053e2ab 100644 --- a/osmo-stp-latest/Dockerfile +++ b/osmo-stp-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ -- To view, visit https://gerrit.osmocom.org/11364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 Gerrit-Change-Number: 11364 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith
Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11364 ) Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. Patch Set 1: this repository has no job that can set the "verified" flag. So you have to set V+1 manually, if you have tested the patch. As it already has review +2, you can then merge it yourself. -- To view, visit https://gerrit.osmocom.org/11364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 Gerrit-Change-Number: 11364 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Sun, 21 Oct 2018 12:16:26 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11364 ) Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. Patch Set 1: Code-Review+2 that may actually have been intentional, i.e. to test the nightly libraries with the "master" of the given application under tests? But yes, that should probably be separate from testing "latest" of both the libraries and the application under test. -- To view, visit https://gerrit.osmocom.org/11364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 Gerrit-Change-Number: 11364 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Tue, 16 Oct 2018 13:45:28 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11364 ) Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 Gerrit-Change-Number: 11364 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Tue, 16 Oct 2018 11:20:56 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11364 Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. osmo-*-latest: s/nightly/latest/g in Dockerfile Follow up to I6a564206dd81743deb1eb27eca7081bc333d7434 where the "*-latest" Dockerfiles were introduced. msc, sgsn, sip, stp had references to "nightly" instead of "latest" in their Dockerfiles. Related: OS#3268 Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 --- M osmo-msc-latest/Dockerfile M osmo-sgsn-latest/Dockerfile M osmo-sip-latest/Dockerfile M osmo-stp-latest/Dockerfile 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/64/11364/1 diff --git a/osmo-msc-latest/Dockerfile b/osmo-msc-latest/Dockerfile index 02298e7..a8cc3ba 100644 --- a/osmo-msc-latest/Dockerfile +++ b/osmo-msc-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ diff --git a/osmo-sgsn-latest/Dockerfile b/osmo-sgsn-latest/Dockerfile index 56b5fda..87dbca2 100644 --- a/osmo-sgsn-latest/Dockerfile +++ b/osmo-sgsn-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ diff --git a/osmo-sip-latest/Dockerfile b/osmo-sip-latest/Dockerfile index 9f978d8..a468c9f 100644 --- a/osmo-sip-latest/Dockerfile +++ b/osmo-sip-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key diff --git a/osmo-stp-latest/Dockerfile b/osmo-stp-latest/Dockerfile index f5920a5..053e2ab 100644 --- a/osmo-stp-latest/Dockerfile +++ b/osmo-stp-latest/Dockerfile @@ -2,7 +2,7 @@ MAINTAINER Harald Welte -ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_9.0/; +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/; COPY Release.key /tmp/Release.key @@ -12,7 +12,7 @@ RUNapt-key add /tmp/Release.key && \ rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list ADD$OSMOCOM_REPO/Release /tmp/Release RUNapt-get update && \ -- To view, visit https://gerrit.osmocom.org/11364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1eab031038927043faf6ed8ed30bdf4d4d1624d5 Gerrit-Change-Number: 11364 Gerrit-PatchSet: 1 Gerrit-Owner: osmith
