Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9379 ) Change subject: ortp: resynchronize rtp session on timestamp changes .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/9379/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9379/3//COMMIT_MSG@7 PS3, Line 7: ortp: resynchronize rtp session on timestamp changes I guess should be "reset rtp session on SSRC changes" -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 30 May 2018 10:53:08 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9379 to look at the new patch set (#3). Change subject: ortp: resynchronize rtp session on timestamp changes .. ortp: resynchronize rtp session on timestamp changes When libortp detects a timestamp jump, we resynchronize the session in order to restore proper rtp frame reception. However, we do not resynchronize on an SSRC change. An SSRC change usually indicates the change of an RTP stream source, which is a much more profound event than a timestamp change, so we should even reset the session on SSRC changes. Also, not resynchronizing the session on an SSRC change causes problems when the jitter buffer feature is used. In those cases it takes libortp a long time until it finally detects the timestamp jump and the session resyhcornization happens late. - reset the ession on SSRC changes by calling rtp_session_reset() Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Related OS#3299 --- M src/trau/osmo_ortp.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/79/9379/3 -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol
Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9379 to look at the new patch set (#2). Change subject: ortp: resynchronize rtp session on timestamp changes .. ortp: resynchronize rtp session on timestamp changes When libortp detects a timestamp jump, we resynchronize the session in order to restore proper rtp frame reception. However, we do not resynchronize on an SSRC change. An SSRC change usually indicates the change of an RTP stream source, which is a much more profound event than a timestamp change, so we should resynchronize the session on SSRC changes as well. Also, not resynchronizing the session on an SSRC change causes problems when the jitter buffer feature is used. In those cases it takes libortp a long time until it finally detects the timestamp jump and the session resyhcornization happens late. Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Related OS#3299 --- M src/trau/osmo_ortp.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/79/9379/2 -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol
Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
dexter has posted comments on this change. ( https://gerrit.osmocom.org/9379 ) Change subject: ortp: resynchronize rtp session on timestamp changes .. Patch Set 1: I am not entirely sure. I have tried both, and both work fine. When I look in the code I can see that the reset functions resets a lot of flags and counters too. I am not sure if this data is still needed or not, but presumably you are right. I will change it for reset. -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 30 May 2018 10:28:21 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9379 ) Change subject: ortp: resynchronize rtp session on timestamp changes .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9379/1/src/trau/osmo_ortp.c File src/trau/osmo_ortp.c: https://gerrit.osmocom.org/#/c/9379/1/src/trau/osmo_ortp.c@118 PS1, Line 118: rtp_session_resync(rs); > What about using rtp_session_reset here? https://www.linphone.org/docs/ortp/rtpsession_8h.html#a87c96ff6a38bd0683165040af5ec1418 -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 30 May 2018 09:30:59 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in libosmo-abis[master]: ortp: resynchronize rtp session on timestamp changes
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9379 ) Change subject: ortp: resynchronize rtp session on timestamp changes .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9379/1/src/trau/osmo_ortp.c File src/trau/osmo_ortp.c: https://gerrit.osmocom.org/#/c/9379/1/src/trau/osmo_ortp.c@118 PS1, Line 118: rtp_session_resync(rs); What about using rtp_session_reset here? -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Wed, 30 May 2018 09:28:39 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
