Change in libosmo-sccp[master]: ASP FSM: Permit DOWN -> DOWN "transition"

2019-12-17 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 )

Change subject: ASP FSM: Permit DOWN -> DOWN "transition"
..

ASP FSM: Permit DOWN -> DOWN "transition"

let's avoid messages like
DLSS7 <000c> xua_asp_fsm.c:600 XUA_ASP(asp-client0){ASP_DOWN}: transition to 
state ASP_DOWN not permitted!

Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 9f30559..2fe2c8a 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -705,7 +705,8 @@
 S(XUA_ASP_E_ASPSM_ASPUP_ACK) |
 S(XUA_ASP_E_ASPSM_ASPDN) |
 S(XUA_ASP_E_SCTP_EST_IND),
-   .out_state_mask = S(XUA_ASP_S_INACTIVE),
+   .out_state_mask = S(XUA_ASP_S_INACTIVE) |
+ S(XUA_ASP_S_DOWN),
.name = "ASP_DOWN",
.action = xua_asp_fsm_down,
.onenter = xua_asp_fsm_down_onenter,

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
Gerrit-Change-Number: 15976
Gerrit-PatchSet: 6
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in libosmo-sccp[master]: ASP FSM: Permit DOWN -> DOWN "transition"

2019-12-17 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 )

Change subject: ASP FSM: Permit DOWN -> DOWN "transition"
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
Gerrit-Change-Number: 15976
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 17 Dec 2019 13:54:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ASP FSM: Permit DOWN -> DOWN "transition"

2019-11-05 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 )

Change subject: ASP FSM: Permit DOWN -> DOWN "transition"
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/15976/3/src/xua_asp_fsm.c@642 
PS3, Line 642:S(XUA_ASP_S_DOWN),
Since probably xua_asp_fsm_down_onenter() is called, it may make sense to do 
something like this in there:

if (prev_state != XUA_ASP_S_DOWN)
  dispatch_to_all_as(fi, XUA_ASPAS_ASP_DOWN_IND);

Because I don't see the point in annoying upper layers if there's no real 
change.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
Gerrit-Change-Number: 15976
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 05 Nov 2019 20:02:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: ASP FSM: Permit DOWN -> DOWN "transition"

2019-11-05 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15976 )


Change subject: ASP FSM: Permit DOWN -> DOWN "transition"
..

ASP FSM: Permit DOWN -> DOWN "transition"

let's avoid messages like
DLSS7 <000c> xua_asp_fsm.c:600 XUA_ASP(asp-client0){ASP_DOWN}: transition to 
state ASP_DOWN not permitted!

Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
---
M src/xua_asp_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/76/15976/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index b3910b2..b704f84 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -634,7 +634,8 @@
 S(XUA_ASP_E_ASPSM_ASPUP_ACK) |
 S(XUA_ASP_E_ASPSM_ASPDN) |
 S(XUA_ASP_E_SCTP_EST_IND),
-   .out_state_mask = S(XUA_ASP_S_INACTIVE),
+   .out_state_mask = S(XUA_ASP_S_INACTIVE) |
+ S(XUA_ASP_S_DOWN),
.name = "ASP_DOWN",
.action = xua_asp_fsm_down,
.onenter = xua_asp_fsm_down_onenter,

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iabbcf92e3022a4c3f165ce19be929915f92b455c
Gerrit-Change-Number: 15976
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange