Change in libosmo-sccp[master]: stp: exit(2) on unsupported positional arguments on command line

2019-12-17 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16644 )

Change subject: stp: exit(2) on unsupported positional arguments on command line
..

stp: exit(2) on unsupported positional arguments on command line

Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
---
M stp/stp_main.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/stp/stp_main.c b/stp/stp_main.c
index 3923ed2..19420c0 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -127,6 +127,11 @@
break;
}
}
+
+   if (argc > optind) {
+   fprintf(stderr, "Unsupported positional arguments in command 
line\n");
+   exit(2);
+   }
 }

 static void signal_handler(int signal)

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
Gerrit-Change-Number: 16644
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in libosmo-sccp[master]: stp: exit(2) on unsupported positional arguments on command line

2019-12-17 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16644 )

Change subject: stp: exit(2) on unsupported positional arguments on command line
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
Gerrit-Change-Number: 16644
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 17 Dec 2019 14:12:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: stp: exit(2) on unsupported positional arguments on command line

2019-12-17 Thread laforge 
Hello pespin, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmo-sccp/+/16644

to look at the new patch set (#2).

Change subject: stp: exit(2) on unsupported positional arguments on command line
..

stp: exit(2) on unsupported positional arguments on command line

Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
---
M stp/stp_main.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/16644/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
Gerrit-Change-Number: 16644
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmo-sccp[master]: stp: exit(2) on unsupported positional arguments on command line

2019-12-17 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16644 )

Change subject: stp: exit(2) on unsupported positional arguments on command line
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/16644/1/stp/stp_main.c
File stp/stp_main.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/16644/1/stp/stp_main.c@132
PS1, Line 132:  fprintf(stderr, "Unsuppoerted positional arguments in 
command line\n");
typo: Unsupported



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
Gerrit-Change-Number: 16644
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 17 Dec 2019 13:57:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: stp: exit(2) on unsupported positional arguments on command line

2019-12-17 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/16644 )


Change subject: stp: exit(2) on unsupported positional arguments on command line
..

stp: exit(2) on unsupported positional arguments on command line

Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
---
M stp/stp_main.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/16644/1

diff --git a/stp/stp_main.c b/stp/stp_main.c
index 3923ed2..61502c8 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -127,6 +127,11 @@
break;
}
}
+
+   if (argc > optind) {
+   fprintf(stderr, "Unsuppoerted positional arguments in command 
line\n");
+   exit(2);
+   }
 }

 static void signal_handler(int signal)

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I70390948943fe42469b8c6d63babc232e857e60c
Gerrit-Change-Number: 16644
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange