Change in libosmocore[master]: exec: osmo_system_nowait2: initalize *pw pointer with NULL

2020-05-12 Thread dexter 
dexter has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/17884 )

Change subject: exec: osmo_system_nowait2: initalize *pw pointer with NULL
..

exec: osmo_system_nowait2: initalize *pw pointer with NULL

The pointer *pw is only populated when the the parameter *user is given,
otherwise it remains uninitalized while it is used later when the
previleges are being dropped.

Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Fixes: CID#209895
---
M src/exec.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/exec.c b/src/exec.c
index 578e2b1..2a03ba8 100644
--- a/src/exec.c
+++ b/src/exec.c
@@ -211,7 +211,8 @@
  */
 int osmo_system_nowait2(const char *command, const char **env_whitelist, char 
**addl_env, const char *user)
 {
-   struct passwd _pw, *pw;
+   struct passwd _pw;
+   struct passwd *pw = NULL;
int getpw_buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
int rc;


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17884
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Gerrit-Change-Number: 17884
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in libosmocore[master]: exec: osmo_system_nowait2: initalize *pw pointer with NULL

2020-04-20 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/17884 )

Change subject: exec: osmo_system_nowait2: initalize *pw pointer with NULL
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17884
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Gerrit-Change-Number: 17884
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 20 Apr 2020 09:32:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: exec: osmo_system_nowait2: initalize *pw pointer with NULL

2020-04-20 Thread dexter 
dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/17884 )


Change subject: exec: osmo_system_nowait2: initalize *pw pointer with NULL
..

exec: osmo_system_nowait2: initalize *pw pointer with NULL

The pointer *pw is only populated when the the parameter *user is given,
otherwise it remains uninitalized while it is used later when the
previleges are being dropped.

Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Fixes: CID#209895
---
M src/exec.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/17884/1

diff --git a/src/exec.c b/src/exec.c
index 578e2b1..2a03ba8 100644
--- a/src/exec.c
+++ b/src/exec.c
@@ -211,7 +211,8 @@
  */
 int osmo_system_nowait2(const char *command, const char **env_whitelist, char 
**addl_env, const char *user)
 {
-   struct passwd _pw, *pw;
+   struct passwd _pw;
+   struct passwd *pw = NULL;
int getpw_buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
int rc;


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17884
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Gerrit-Change-Number: 17884
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange