Change in libosmocore[master]: fix api doc for osmo_bcd2str()
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12235 ) Change subject: fix api doc for osmo_bcd2str() .. fix api doc for osmo_bcd2str() Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Neels Hofmeyr: Looks good to me, approved diff --git a/src/utils.c b/src/utils.c index 4b4e6d2..35d70ac 100644 --- a/src/utils.c +++ b/src/utils.c @@ -136,7 +136,7 @@ * \param[in] dst_size sizeof() the output string buffer. * \param[in] bcd Binary coded data buffer. * \param[in] start_nibble Offset to start from, in nibbles, typically 1 to skip the first nibble. - * \param[in] end_nibble Offset to stop before, in nibbles, e.g. sizeof(bcd) - (bcd[0] & GSM_MI_ODD? 0:1). + * \param[in] end_nibble Offset to stop before, in nibbles, e.g. sizeof(bcd)*2 - (bcd[0] & GSM_MI_ODD? 0:1). * \param[in] allow_hex If false, return error if there are digits other than 0-9. If true, return those as [A-F]. * \returns The strlen that would be written if the output buffer is large enough, excluding nul byte (like * snprintf()), or -EINVAL if allow_hex is false and a digit > 9 is encountered. On -EINVAL, the conversion is -- To view, visit https://gerrit.osmocom.org/12235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e Gerrit-Change-Number: 12235 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr
Change in libosmocore[master]: fix api doc for osmo_bcd2str()
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12235 ) Change subject: fix api doc for osmo_bcd2str() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e Gerrit-Change-Number: 12235 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Tue, 11 Dec 2018 01:18:01 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: fix api doc for osmo_bcd2str()
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12235 Change subject: fix api doc for osmo_bcd2str() .. fix api doc for osmo_bcd2str() Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e --- M src/utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/12235/1 diff --git a/src/utils.c b/src/utils.c index 4b4e6d2..35d70ac 100644 --- a/src/utils.c +++ b/src/utils.c @@ -136,7 +136,7 @@ * \param[in] dst_size sizeof() the output string buffer. * \param[in] bcd Binary coded data buffer. * \param[in] start_nibble Offset to start from, in nibbles, typically 1 to skip the first nibble. - * \param[in] end_nibble Offset to stop before, in nibbles, e.g. sizeof(bcd) - (bcd[0] & GSM_MI_ODD? 0:1). + * \param[in] end_nibble Offset to stop before, in nibbles, e.g. sizeof(bcd)*2 - (bcd[0] & GSM_MI_ODD? 0:1). * \param[in] allow_hex If false, return error if there are digits other than 0-9. If true, return those as [A-F]. * \returns The strlen that would be written if the output buffer is large enough, excluding nul byte (like * snprintf()), or -EINVAL if allow_hex is false and a digit > 9 is encountered. On -EINVAL, the conversion is -- To view, visit https://gerrit.osmocom.org/12235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I504ea849fc9daeb34a1b3c5343371161deba743e Gerrit-Change-Number: 12235 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr
