Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

2020-12-15 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21709 )

Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
..

gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

Cherry-pick from osmo-bsc.git e981f17200bf3a5d5114f46d9f7515fd10b96dbb

Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index dd14d28..84b7589 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -909,13 +909,8 @@
/* EGPRS supported in the cell */
bitvec_set_bit(bv, 1);

-   /* 1bit EGPRS PACKET CHANNEL REQUEST */
-   if (gco->supports_egprs_11bit_rach == 0) {
-   bitvec_set_bit(bv,
-   gco->ext_info.use_egprs_p_ch_req);
-   } else {
-   bitvec_set_bit(bv, 0);
-   }
+   /* 1bit EGPRS PACKET CHANNEL REQUEST (inverted logic) */
+   bitvec_set_bit(bv, !gco->ext_info.use_egprs_p_ch_req);

/* 4bit BEP PERIOD */
bitvec_set_uint(bv, gco->ext_info.bep_period, 4);

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

2020-12-14 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21709 )

Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 14 Dec 2020 17:58:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

2020-12-14 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21709 )

Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Mon, 14 Dec 2020 17:32:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

2020-12-14 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21709 )


Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
..

gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST

Cherry-pick from osmo-bsc.git e981f17200bf3a5d5114f46d9f7515fd10b96dbb

Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/21709/1

diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index dd14d28..84b7589 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -909,13 +909,8 @@
/* EGPRS supported in the cell */
bitvec_set_bit(bv, 1);

-   /* 1bit EGPRS PACKET CHANNEL REQUEST */
-   if (gco->supports_egprs_11bit_rach == 0) {
-   bitvec_set_bit(bv,
-   gco->ext_info.use_egprs_p_ch_req);
-   } else {
-   bitvec_set_bit(bv, 0);
-   }
+   /* 1bit EGPRS PACKET CHANNEL REQUEST (inverted logic) */
+   bitvec_set_bit(bv, !gco->ext_info.use_egprs_p_ch_req);

/* 4bit BEP PERIOD */
bitvec_set_uint(bv, gco->ext_info.bep_period, 4);

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange