Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

2019-01-28 Thread Neels Hofmeyr 
Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12670 )

Change subject: osmo_fsm_state_name: make robust against NULL fi
..

osmo_fsm_state_name: make robust against NULL fi

Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
---
M include/osmocom/core/fsm.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve



diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index 5bf5328..df7e348 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -220,7 +220,7 @@

 /*! return the name of the state the FSM instance is currently in. */
 static inline const char *osmo_fsm_inst_state_name(struct osmo_fsm_inst *fi)
-{ return osmo_fsm_state_name(fi->fsm, fi->state); }
+{ return fi ? osmo_fsm_state_name(fi->fsm, fi->state) : "NULL"; }

 /*! perform a state change of the given FSM instance
  *

--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy

Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

2019-01-25 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12670 )

Change subject: osmo_fsm_state_name: make robust against NULL fi
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 25 Jan 2019 11:52:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

2019-01-24 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12670 )

Change subject: osmo_fsm_state_name: make robust against NULL fi
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:26:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

2019-01-21 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/12670 )

Change subject: osmo_fsm_state_name: make robust against NULL fi
..

osmo_fsm_state_name: make robust against NULL fi

Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
---
M include/osmocom/core/fsm.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/12670/2
--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr

Change in libosmocore[master]: osmo_fsm_state_name: make robust against NULL fi

2019-01-21 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12670


Change subject: osmo_fsm_state_name: make robust against NULL fi
..

osmo_fsm_state_name: make robust against NULL fi

Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
---
M include/osmocom/core/fsm.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/12670/1

diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index 5bf5328..df7e348 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -220,7 +220,7 @@

 /*! return the name of the state the FSM instance is currently in. */
 static inline const char *osmo_fsm_inst_state_name(struct osmo_fsm_inst *fi)
-{ return osmo_fsm_state_name(fi->fsm, fi->state); }
+{ return fi ? osmo_fsm_state_name(fi->fsm, fi->state) : "NULL"; }

 /*! perform a state change of the given FSM instance
  *

--
To view, visit https://gerrit.osmocom.org/12670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d4f7dfada2763948f330745ac886405d889a12
Gerrit-Change-Number: 12670
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr