Change in libosmocore[master]: platform independence fix: tdef range tests
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12841 ) Change subject: platform independence fix: tdef range tests .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 Gerrit-Change-Number: 12841 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Wed, 06 Feb 2019 12:34:44 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: platform independence fix: tdef range tests
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12841 ) Change subject: platform independence fix: tdef range tests .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 Gerrit-Change-Number: 12841 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Wed, 06 Feb 2019 01:05:34 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: platform independence fix: tdef range tests
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12841 to look at the new patch set (#4). Change subject: platform independence fix: tdef range tests .. platform independence fix: tdef range tests Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic testing. This will hopefully fix recent build failures on various platforms. Add a 64 bit output example for expected results when invoking `./tdef_test range'. This is not checked automatically and merely serves for manual reference. For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX. Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 --- M tests/Makefile.am M tests/tdef/tdef_test.c M tests/tdef/tdef_test.ok A tests/tdef/tdef_test_range_64bit.ok M tests/tdef/tdef_vty_test_config_root.c M tests/tdef/tdef_vty_test_config_root.vty M tests/tdef/tdef_vty_test_config_subnode.c M tests/tdef/tdef_vty_test_config_subnode.vty 8 files changed, 490 insertions(+), 133 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/4 -- To view, visit https://gerrit.osmocom.org/12841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 Gerrit-Change-Number: 12841 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102)
Change in libosmocore[master]: platform independence fix: tdef range tests
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12841 to look at the new patch set (#3). Change subject: platform independence fix: tdef range tests .. platform independence fix: tdef range tests Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic testing. This will hopefully fix recent build failures on various platforms. Add a 64 bit output example for expected results when invoking `./tdef_test range'. This is not checked automatically and merely serves for manual reference. For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX. Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 --- M tests/Makefile.am M tests/tdef/tdef_test.c M tests/tdef/tdef_test.ok A tests/tdef/tdef_test_range_64bit.ok M tests/tdef/tdef_vty_test_config_root.c M tests/tdef/tdef_vty_test_config_root.vty M tests/tdef/tdef_vty_test_config_subnode.c M tests/tdef/tdef_vty_test_config_subnode.vty 8 files changed, 488 insertions(+), 131 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/3 -- To view, visit https://gerrit.osmocom.org/12841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 Gerrit-Change-Number: 12841 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102)
Change in libosmocore[master]: platform independence fix: tdef range tests
Neels Hofmeyr has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12841 ) Change subject: platform independence fix: tdef range tests .. platform independence fix: tdef range tests Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic testing. This will hopefully fix recent build failures on various platforms. Add a 64 bit output example for expected results when invoking `./tdef_test range'. This is not checked automatically and merely serves for manual reference. For vty tests, use 32bit max values instead of INT_MAX and ULONG_MAX. Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 --- M tests/Makefile.am M tests/tdef/tdef_test.c M tests/tdef/tdef_test.ok A tests/tdef/tdef_test_range_64bit.ok M tests/tdef/tdef_vty_test_config_root.c M tests/tdef/tdef_vty_test_config_root.vty M tests/tdef/tdef_vty_test_config_subnode.c M tests/tdef/tdef_vty_test_config_subnode.vty 8 files changed, 471 insertions(+), 114 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/2 -- To view, visit https://gerrit.osmocom.org/12841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2 Gerrit-Change-Number: 12841 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr Gerrit-CC: Jenkins Builder (102)
Change in libosmocore[master]: platform independence fix: tdef range tests
Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/12841
Change subject: platform independence fix: tdef range tests
..
platform independence fix: tdef range tests
Run INT_MAX and ULONG_MAX related tests only manually, remove from automatic
testing. This will hopefully fix recent build failures on various platforms.
Add a 64 bit output example for expected results when invoking
`./tdef_test range'. This is not checked automatically and merely serves for
manual reference.
Change-Id: I6242243bde1d7ddebb858512a1f0b07f4ec3e5c2
---
M tests/Makefile.am
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
A tests/tdef/tdef_test_range_64bit.ok
4 files changed, 457 insertions(+), 100 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12841/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 54fb11f..63f3959 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -300,6 +300,7 @@
oap/oap_client_test.ok oap/oap_client_test.err \
vty/vty_transcript_test.vty\
tdef/tdef_test.ok \
+tdef/tdef_test_range_64bit.ok \
tdef/tdef_vty_test_config_root.vty \
tdef/tdef_vty_test_config_subnode.vty \
tdef/tdef_vty_test_dynamic.vty \
diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c
index 682c7ac..c08a158 100644
--- a/tests/tdef/tdef_test.c
+++ b/tests/tdef/tdef_test.c
@@ -49,21 +49,12 @@
/* test conversions */
{ .T=1000, .default_val=2*1000, .unit=OSMO_TDEF_MS, .desc="two seconds
from ms" },
{ .T=1001, .default_val=60*1000, .unit=OSMO_TDEF_MS, .desc="one minute
from ms" },
- { .T=1002, .default_val=(ULONG_MAX/60), .unit=OSMO_TDEF_M,
.desc="almost too many seconds" },
- { .T=1003, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="too many
seconds" },
{ .T=1004, .default_val=1, .unit=OSMO_TDEF_MS, .desc="one ms" },
{ .T=1005, .default_val=0, .unit=OSMO_TDEF_MS, .desc="zero ms" },
{ .T=1006, .default_val=0, .unit=OSMO_TDEF_S, .desc="zero s" },
{ .T=1007, .default_val=0, .unit=OSMO_TDEF_M, .desc="zero m" },
{ .T=1008, .default_val=0, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },
- /* test range */
- { .T=INT_MAX, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, .desc="very
large" },
- { .T=INT_MAX-1, .default_val=ULONG_MAX-1, .unit=OSMO_TDEF_S,
.desc="very large" },
- { .T=INT_MAX-2, .default_val=LONG_MAX, .unit=OSMO_TDEF_S, .desc="very
large" },
- { .T=INT_MAX-3, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="very
large in minutes" },
- { .T=INT_MIN, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S,
.desc="negative" },
-
{ .T=0, .default_val=1, .unit=OSMO_TDEF_CUSTOM, .desc="zero" },
/* no desc */
@@ -72,13 +63,26 @@
{} // <-- important! last entry shall be zero
};
-#define print_tdef_get(T, AS_UNIT) do { \
- unsigned long val = osmo_tdef_get(tdefs, T, AS_UNIT, 999); \
+static struct osmo_tdef tdefs_range[] = {
+ { .T=1002, .default_val=(ULONG_MAX/60), .unit=OSMO_TDEF_M,
.desc="almost too many seconds" },
+ { .T=1003, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="too many
seconds" },
+
+ { .T=INT_MAX, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S, .desc="very
large" },
+ { .T=INT_MAX-1, .default_val=ULONG_MAX-1, .unit=OSMO_TDEF_S,
.desc="very large" },
+ { .T=INT_MAX-2, .default_val=LONG_MAX, .unit=OSMO_TDEF_S, .desc="very
large" },
+ { .T=INT_MAX-3, .default_val=ULONG_MAX, .unit=OSMO_TDEF_M, .desc="very
large in minutes" },
+ { .T=INT_MIN, .default_val=ULONG_MAX, .unit=OSMO_TDEF_S,
.desc="negative" },
+
+ {}
+};
+
+#define print_tdef_get(TDEFS, T, AS_UNIT) do { \
+ unsigned long val = osmo_tdef_get(TDEFS, T, AS_UNIT, 999); \
printf("osmo_tdef_get(tdefs, %d, %s, 999)\t= %lu\n", T,
osmo_tdef_unit_name(AS_UNIT), val); \
} while (0)
-#define print_tdef_get_short(T, AS_UNIT) do { \
- unsigned long val = osmo_tdef_get(tdefs, T, AS_UNIT, 999); \
+#define print_tdef_get_short(TDEFS, T, AS_UNIT) do { \
+ unsigned long val = osmo_tdef_get(TDEFS, T, AS_UNIT, 999); \
printf("osmo_tdef_get(%d, %s)\t= %lu\n", T,
osmo_tdef_unit_name(AS_UNIT), val); \
} while (0)
@@ -95,7 +99,7 @@
printf("\n");
}
-static void test_tdef_get()
+static void test_tdef_get(bool test_range)
{
int i;
enum osmo_tdef_unit as_unit;
@@ -108,7 +112,18 @@
unsigned int T = tdefs[i].T;
print_tdef_info(T);
for (as_unit = OSMO_TDEF_S; as_unit <= OSMO_TDEF_CUSTOM;
as_unit++) {
- print_tdef_get_short(T, as_unit);
+ print_tdef_get_short(tdefs, T, as_unit);
+ }
+ }
+
+
