Change in libosmocore[master]: tests: gea_test: Use correct max size for key in buffer

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9206 )

Change subject: tests: gea_test: Use correct max size for key in buffer
..

tests: gea_test: Use correct max size for key in buffer

Expect key sizes for GEA are 64-128 bits.

Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
---
M tests/gea/gea_test.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/tests/gea/gea_test.c b/tests/gea/gea_test.c
index ebccaaf..87020e2 100644
--- a/tests/gea/gea_test.c
+++ b/tests/gea/gea_test.c
@@ -23,9 +23,9 @@
 static inline void test_gea(bool v4, char *kc, uint32_t iv, int dir,
uint16_t len, char *res)
 {
-uint8_t out[len], ck[256];
+uint8_t out[len], ck[16];
 printf("len %d, dir %d, INPUT 0x%X -> ", len, dir, iv);
-osmo_hexparse(kc, ck, len);
+osmo_hexparse(kc, ck, sizeof(ck));
 int t = gprs_cipher_run(out, len, v4 ? GPRS_ALGO_GEA4 : GPRS_ALGO_GEA3, ck,
iv, dir);
 printf("%s ", t < 0 ? strerror(-t) : "OK");

--
To view, visit https://gerrit.osmocom.org/9206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
Gerrit-Change-Number: 9206
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: tests: gea_test: Use correct max size for key in buffer

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9206 )

Change subject: tests: gea_test: Use correct max size for key in buffer
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
Gerrit-Change-Number: 9206
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 17 May 2018 07:12:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: tests: gea_test: Use correct max size for key in buffer

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9206 )

Change subject: tests: gea_test: Use correct max size for key in buffer
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
Gerrit-Change-Number: 9206
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 16 May 2018 23:03:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: tests: gea_test: Use correct max size for key in buffer

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9206


Change subject: tests: gea_test: Use correct max size for key in buffer
..

tests: gea_test: Use correct max size for key in buffer

Expect key sizes for GEA are 64-128 bits.

Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
---
M tests/gea/gea_test.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/9206/1

diff --git a/tests/gea/gea_test.c b/tests/gea/gea_test.c
index ebccaaf..87020e2 100644
--- a/tests/gea/gea_test.c
+++ b/tests/gea/gea_test.c
@@ -23,9 +23,9 @@
 static inline void test_gea(bool v4, char *kc, uint32_t iv, int dir,
uint16_t len, char *res)
 {
-uint8_t out[len], ck[256];
+uint8_t out[len], ck[16];
 printf("len %d, dir %d, INPUT 0x%X -> ", len, dir, iv);
-osmo_hexparse(kc, ck, len);
+osmo_hexparse(kc, ck, sizeof(ck));
 int t = gprs_cipher_run(out, len, v4 ? GPRS_ALGO_GEA4 : GPRS_ALGO_GEA3, ck,
iv, dir);
 printf("%s ", t < 0 ? strerror(-t) : "OK");

--
To view, visit https://gerrit.osmocom.org/9206
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf81992a2901733b630e3046b0c4bdc1fb9a8ace
Gerrit-Change-Number: 9206
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol