Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Keith Whyte 
Keith Whyte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12603 )

Change subject: Cosmetic: Fix spelling in smpp vty
..

Cosmetic: Fix spelling in smpp vty

Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
---
M openbsc/src/libmsc/smpp_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c
index ff0314e..f1df652 100644
--- a/openbsc/src/libmsc/smpp_vty.c
+++ b/openbsc/src/libmsc/smpp_vty.c
@@ -164,7 +164,7 @@
 DEFUN(cfg_smpp_policy, cfg_smpp_policy_cmd,
"policy (accept-all|closed)",
"Set the authentication policy of this SMSC\n"
-   "Accept all SMPP connections independeint of system ID / passwd\n"
+   "Accept all SMPP connections independent of system ID / password\n"
"Accept only SMPP connections from ESMEs explicitly configured")
 {
struct smsc *smsc = smsc_from_vty(vty);
@@ -541,7 +541,7 @@

 DEFUN(show_esme, show_esme_cmd,
"show smpp esme",
-   SHOW_STR "SMPP Interface\n" "SMPP Extrenal SMS Entity\n")
+   SHOW_STR "SMPP Interface\n" "SMPP External SMS Entity\n")
 {
struct smsc *smsc = smsc_from_vty(vty);
struct osmo_esme *esme;

--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12603 )

Change subject: Cosmetic: Fix spelling in smpp vty
..


Patch Set 1: Code-Review+2

forget my earlier comments, I now saw the MSC changes. Thanks!


--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 17 Jan 2019 12:17:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12603 )

Change subject: Cosmetic: Fix spelling in smpp vty
..


Patch Set 1:

good patch, but similarly, we should always work "mainline first" and then 
back-port to openbsc.git. Thanks!


--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 17 Jan 2019 12:17:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12603 )

Change subject: Cosmetic: Fix spelling in smpp vty
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 17 Jan 2019 11:22:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12603 )

Change subject: Cosmetic: Fix spelling in smpp vty
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 17 Jan 2019 10:07:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-16 Thread Keith Whyte 
Keith Whyte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12603


Change subject: Cosmetic: Fix spelling in smpp vty
..

Cosmetic: Fix spelling in smpp vty

Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
---
M openbsc/src/libmsc/smpp_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/03/12603/1

diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c
index ff0314e..f1df652 100644
--- a/openbsc/src/libmsc/smpp_vty.c
+++ b/openbsc/src/libmsc/smpp_vty.c
@@ -164,7 +164,7 @@
 DEFUN(cfg_smpp_policy, cfg_smpp_policy_cmd,
"policy (accept-all|closed)",
"Set the authentication policy of this SMSC\n"
-   "Accept all SMPP connections independeint of system ID / passwd\n"
+   "Accept all SMPP connections independent of system ID / password\n"
"Accept only SMPP connections from ESMEs explicitly configured")
 {
struct smsc *smsc = smsc_from_vty(vty);
@@ -541,7 +541,7 @@

 DEFUN(show_esme, show_esme_cmd,
"show smpp esme",
-   SHOW_STR "SMPP Interface\n" "SMPP Extrenal SMS Entity\n")
+   SHOW_STR "SMPP Interface\n" "SMPP External SMS Entity\n")
 {
struct smsc *smsc = smsc_from_vty(vty);
struct osmo_esme *esme;

--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2180828e2acd28d96754c593c317c2868644c4b
Gerrit-Change-Number: 12603
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte