Change in openbsc[master]: bsc-nat: Add -V param to print version

2018-06-18 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9642 )

Change subject: bsc-nat: Add -V param to print version
..

bsc-nat: Add -V param to print version

Change-Id: I4dbf97905749aa9379bc6b6b448953d8b1825545
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index a9f1c0b..ba7f542 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1465,6 +1465,7 @@
printf("  -D --daemonize Fork the process into a background daemon\n");
printf("  -s --disable-color\n");
printf("  -T --timestamp. Print a timestamp in the debug output.\n");
+   printf("  -V --version. Print the version of OsmoBSCNAT.\n");
printf("  -c --config-file filename The config file to use.\n");
printf("  -m --msc=IP. The address of the MSC.\n");
printf("  -l --local=IP. The local address of this BSC.\n");
@@ -1481,12 +1482,13 @@
{"config-file", 1, 0, 'c'},
{"disable-color", 0, 0, 's'},
{"timestamp", 0, 0, 'T'},
+   {"version", 0, 0, 'V' },
{"msc", 1, 0, 'm'},
{"local", 1, 0, 'l'},
{0, 0, 0, 0}
};

-   c = getopt_long(argc, argv, "hd:sTPc:m:l:D",
+   c = getopt_long(argc, argv, "hd:sTVPc:m:l:D",
long_options, _index);
if (c == -1)
break;
@@ -1511,6 +1513,10 @@
case 'T':
log_set_print_timestamp(osmo_stderr_target, 1);
break;
+   case 'V':
+   print_version(1);
+   exit(0);
+   break;
case 'm':
msc_ip = optarg;
break;

--
To view, visit https://gerrit.osmocom.org/9642
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4dbf97905749aa9379bc6b6b448953d8b1825545
Gerrit-Change-Number: 9642
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol

Change in openbsc[master]: bsc-nat: Add -V param to print version

2018-06-15 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9642 )

Change subject: bsc-nat: Add -V param to print version
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9642
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dbf97905749aa9379bc6b6b448953d8b1825545
Gerrit-Change-Number: 9642
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 15 Jun 2018 14:50:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: bsc-nat: Add -V param to print version

2018-06-15 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9642


Change subject: bsc-nat: Add -V param to print version
..

bsc-nat: Add -V param to print version

Change-Id: I4dbf97905749aa9379bc6b6b448953d8b1825545
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/42/9642/1

diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index a9f1c0b..ba7f542 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1465,6 +1465,7 @@
printf("  -D --daemonize Fork the process into a background daemon\n");
printf("  -s --disable-color\n");
printf("  -T --timestamp. Print a timestamp in the debug output.\n");
+   printf("  -V --version. Print the version of OsmoBSCNAT.\n");
printf("  -c --config-file filename The config file to use.\n");
printf("  -m --msc=IP. The address of the MSC.\n");
printf("  -l --local=IP. The local address of this BSC.\n");
@@ -1481,12 +1482,13 @@
{"config-file", 1, 0, 'c'},
{"disable-color", 0, 0, 's'},
{"timestamp", 0, 0, 'T'},
+   {"version", 0, 0, 'V' },
{"msc", 1, 0, 'm'},
{"local", 1, 0, 'l'},
{0, 0, 0, 0}
};

-   c = getopt_long(argc, argv, "hd:sTPc:m:l:D",
+   c = getopt_long(argc, argv, "hd:sTVPc:m:l:D",
long_options, _index);
if (c == -1)
break;
@@ -1511,6 +1513,10 @@
case 'T':
log_set_print_timestamp(osmo_stderr_target, 1);
break;
+   case 'V':
+   print_version(1);
+   exit(0);
+   break;
case 'm':
msc_ip = optarg;
break;

--
To view, visit https://gerrit.osmocom.org/9642
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dbf97905749aa9379bc6b6b448953d8b1825545
Gerrit-Change-Number: 9642
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol