Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10937 ) Change subject: nat: return -EBADF in read wqueue cb on fd closed .. nat: return -EBADF in read wqueue cb on fd closed bsc_msc_lost will close the current fd (without freeing it), so let's skip possible writes to an already closed fd bsc_msc_lost will close the current fd (without freeing it), so let's skip possible writes to an already closed fd.. Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa --- M openbsc/src/osmo-bsc_nat/bsc_nat.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 8cc0f2d..c8a9e74 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -864,7 +864,7 @@ msc_con->name, ret); bsc_msc_lost(msc_con); - return -1; + return -EBADF; } LOGP(DNAT, LOGL_DEBUG, -- To view, visit https://gerrit.osmocom.org/10937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa Gerrit-Change-Number: 10937 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10937 ) Change subject: nat: return -EBADF in read wqueue cb on fd closed .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa Gerrit-Change-Number: 10937 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Sat, 15 Sep 2018 09:22:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10937 Change subject: nat: return -EBADF in read wqueue cb on fd closed .. nat: return -EBADF in read wqueue cb on fd closed bsc_msc_lost will close the current fd (without freeing it), so let's skip possible writes to an already closed fd bsc_msc_lost will close the current fd (without freeing it), so let's skip possible writes to an already closed fd.. Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa --- M openbsc/src/osmo-bsc_nat/bsc_nat.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/37/10937/1 diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 8cc0f2d..c8a9e74 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -864,7 +864,7 @@ msc_con->name, ret); bsc_msc_lost(msc_con); - return -1; + return -EBADF; } LOGP(DNAT, LOGL_DEBUG, -- To view, visit https://gerrit.osmocom.org/10937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa Gerrit-Change-Number: 10937 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
